Auto Filament Change Reworked: finally working by clexpert · Pull Request #3638 · MarlinFirmware/Marlin

clexpert · 2016-04-28T17:58:12Z

(Don't mix up with Manual filament change #3605)

Background

Months ago, someone suggested reworking (or at leats make existing function work) Auto filament change in #2926 and #2933. This function is working (as mentioned there) in Prusa's firmware and many other closed-source 3D printer. But neither of them is sufficient to be publicated for community of most used 3D firmware, with variety of printers, extruders and displays. So we started working on complete rewrite of filament change function, to make it work for us and then make it open to everyone here on GitHub.

Functions

This change rewrites Auto Filament Change controlled by G-Code M600.
The procedure of change is:

Retract a bit and move axis to position set by Configuration or by G-Code parameters
Unload filament
Keep beeping and wait for user to insert filament and click on button (encoder)
Load filament through bowden (see Configuration for details)
Extrude some filament and ask user either to extrude more or to resume print
Move axis back and continue printing
Every step is clearly documented with information messages displayed on the display. As suggested by others, KEEP_ALIVE is also used. Simple working procedure makes it easy to change filament for everyone.

TODO list for community

Check behaviour on DELTA printers
Choose load and extrude distances for all example printers
Translate messages

jbrazio · 2016-04-28T18:10:12Z

Marlin/Configuration_adv.h

-    #define AUTO_FILAMENT_CHANGE                //This extrude filament until you press the button on LCD
-    #define AUTO_FILAMENT_CHANGE_LENGTH 0.04    //Extrusion length on automatic extrusion loop
-    #define AUTO_FILAMENT_CHANGE_FEEDRATE 300   //Extrusion feedrate (mm/min) on automatic extrusion loop
+  #define FILAMENT_CHANGE_ENABLE                // Enable filament exchange menu and M600 g-code (used for runout sensor too)


We should keep it disabled by default.

jbrazio · 2016-04-28T18:19:40Z

Marlin/Marlin_main.cpp

-    #endif
-
-    //return to normal
+      millis_t ms = millis();


The buzz block should be inside #if HAS_BUZZER.

@clexpert if ms is not used elsewhere I would suggest:

#if HAS_BUZZER millis_t ms = millis(); if (ms >= next_tick) { buzz(300, 2000); next_tick = ms + 2500; // Beep every 2.5s while waiting } #endif

jbrazio · 2016-04-28T18:26:45Z

Marlin/ultralcd.h

    void lcd_buttons_update();
    extern volatile uint8_t buttons;  //the last checked buttons in a bit array.
+    #if ENABLED(FILAMENT_CHANGE_ENABLE)
+      enum FilamentChangeMessage {


Remove the attributions from the enum:

enum FilamentChangeMessage { FILAMENT_CHANGE_MESSAGE_INIT, FILAMENT_CHANGE_MESSAGE_UNLOAD, FILAMENT_CHANGE_MESSAGE_INSERT, FILAMENT_CHANGE_MESSAGE_LOAD, FILAMENT_CHANGE_MESSAGE_EXTRUDE, FILAMENT_CHANGE_MESSAGE_OPTION, FILAMENT_CHANGE_MESSAGE_RESUME, FILAMENT_CHANGE_MESSAGE_STATUS };

jbrazio · 2016-04-28T18:28:33Z

@clexpert good work this seems to be very promising, a proper process to handle filament changes on single extruder setups was really missing in Marlin.

jbrazio · 2016-04-28T18:55:13Z

@clexpert may I suggest a rebase of this PR using git rebase -i origin/RCBugFix, some of the commits could be merged together by fixup.

clexpert · 2016-04-28T19:02:41Z

@jbrazio Thank you very much for all your quick comments. I corrected all your remarks. So I use web based github only so I cannot merge commits together.

Spoonunit · 2016-04-28T22:14:24Z

Is there anything in here that will prevent this from working with multiple extruders? i.e., if T1 is the active tool, that should be the tool where the retraction occurs. If a position to move to is configured, this should honor any M218 settings. Just a thought as multiple extruders aren't always multiple colors, but sometimes multiple materials (soluble support for example). Many thanks for working auto filament change whatever the response :)

jbrazio · 2016-04-28T22:21:50Z

That is a very interesting point @Spoonunit, M600 should affect the current selected tool and honor any active offset when moving to the material change position.

jbrazio · 2016-04-28T22:23:36Z

Marlin/Marlin_main.cpp

-    #ifdef FILAMENTCHANGE_ZADD
-      else destination[Z_AXIS] += FILAMENTCHANGE_ZADD;
+      #ifdef FILAMENT_CHANGE_Z_ADD
+        else destination[Z_AXIS] += FILAMENT_CHANGE_Z_ADD;


An improvement suggestion, this should check if the move will not go over Z-Max.

clexpert · 2016-04-29T12:45:11Z

@jbrazio Thanks for the idea. I will check it and update today.

clexpert · 2016-05-01T16:16:17Z

@jbrazio Z_MAX_POS checking is done. But I have a problem with "This branch has conflicts that must be resolved". Please, would you help me?

jbrazio · 2016-05-01T22:45:11Z

@clexpert This requires some git ninja skills as @thinkyhead did some refactoring on functions that are now methods and your code is still using the function names. When this is merged I'm sure @thinkyhead will resolve those conflicts or I can step in to help you out on the command line as it seems you're lacking the skills.

Do you consider this rework done thus ready to be merged ?

clexpert · 2016-05-01T23:48:25Z

@jbrazio It would be nice :-) Yes, I am sure that this rework is ready to be merged. I tested it on my 3D printer without any problem. I only think that it needs test on delta printer. I think that @thinkyhead has the one.

jbrazio · 2016-05-02T00:03:00Z

@thinkyhead is running a Prusa i3, Delta.. @Roxy-3DPrintBoard has one and @CONSULitAS also has a Kossel I believe.

thinkyhead · 2016-05-02T03:41:10Z

I've made a copy of this branch and will patch it up and rebase it to the latest RCBugFix code. When it's ready I will post it under a new PR.

git remote add clexpert git@github.com:clexpert/Marlin.git
git fetch clexpert
git checkout clexpert/RCBugFix -b rc_fixup_auto_filament_change
git rebase RCBugFix
...
git rebase -i RCBugFix

CONSULitAS · 2016-05-02T10:38:08Z

@jbrazio
I have a modified K8200/3Drag (cartesian with E3D V6 hotend and Wade like extruder).

Would like to test asap. But i am rather busy now.

thinkyhead · 2016-05-02T22:11:47Z

This is moved over to #3662, rebased on the latest code with excess commits squashed.

TM: Consume LCD click after calibration

clexpert added 10 commits April 28, 2016 18:57

Rename FILAMENTCHANGEENABLE in SanityCheck.h

8b84531

Add LCD messages for filament change

1f774f1

Complete rewrite M600 filament change function

736c03c

Changes for M600 filament change

bc9cffe

Status enum for M600 filament change

5762293

Czech translation for M600 filament change

bd7e30c

Czech translation for M600 filament change

3b0ae05

English messages for M600 filament change

30c8124

Update Configuration_adv.h

5fa3a0e

Update for FILAMENT_CHANGE_ENABLE

1952c01

jbrazio reviewed Apr 28, 2016
View reviewed changes

Disable M600 filament change by default

faf5d8a

jbrazio reviewed Apr 28, 2016
View reviewed changes

clexpert added 2 commits April 28, 2016 20:19

Status enum for M600 filament change correct

c4868e0

Buzzer condition and error at start for M600

cf7c549

jbrazio reviewed Apr 28, 2016
View reviewed changes

jbrazio added PR: Improvement PR: New Feature labels Apr 28, 2016

Message enum for M600 filament change correct

eb10218

Bad text correction

64cc863

Buzzer condition for M600 correction

cc37cfc

jbrazio reviewed Apr 28, 2016
View reviewed changes

Z_MAX_POS checking for lift in M600

c76488f

thinkyhead mentioned this pull request May 2, 2016

Rewritten FILAMENT_CHANGE_ENABLE feature #3662

Merged

3 tasks

thinkyhead closed this May 2, 2016

jbrazio modified the milestone: 1.1.0 Jul 18, 2016

drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023

Merge pull request MarlinFirmware#3638 from wavexx/tm_cal_click

629fc9d

TM: Consume LCD click after calibration

Uh oh!

Conversation

clexpert commented Apr 28, 2016

Background

Functions

TODO list for community

Uh oh!

jbrazio Apr 28, 2016

Choose a reason for hiding this comment

Uh oh!

jbrazio Apr 28, 2016

Choose a reason for hiding this comment

Uh oh!

jbrazio Apr 28, 2016

Choose a reason for hiding this comment

Uh oh!

jbrazio Apr 28, 2016

Choose a reason for hiding this comment

Uh oh!

jbrazio commented Apr 28, 2016

Uh oh!

jbrazio commented Apr 28, 2016

Uh oh!

clexpert commented Apr 28, 2016

Uh oh!

Spoonunit commented Apr 28, 2016

Uh oh!

jbrazio commented Apr 28, 2016

Uh oh!

jbrazio Apr 28, 2016

Choose a reason for hiding this comment

Uh oh!

clexpert commented Apr 29, 2016

Uh oh!

clexpert commented May 1, 2016 • edited by thinkyhead Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbrazio commented May 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clexpert commented May 1, 2016

Uh oh!

jbrazio commented May 2, 2016

Uh oh!

thinkyhead commented May 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CONSULitAS commented May 2, 2016

Uh oh!

thinkyhead commented May 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

clexpert commented May 1, 2016 •

edited by thinkyhead

Loading

jbrazio commented May 1, 2016 •

edited

Loading

thinkyhead commented May 2, 2016 •

edited

Loading