FTM: fix resonance test motion and optimize compute #28266
Merged
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This code indeed fixes the issue mentioned in #28263 , please merge asap, as the current state of bugfix-2.1 can result in an unusable firmware. |
thinkyhead
pushed a commit
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After last code merge :
fast_sin()as the value range is not -π <= r <= π, fixed.exp2fprecalculated outside the loop.Requirements
Benefits
Test works as intended, more optimization for MCU without FPU
Fix broken resonance frequency calculation in motion menu
Configurations
Related Issues