Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT_MOTION: Disable FT-MOTION for homing and probing for Biqu Microprobe #27368

Open
wants to merge 13 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

narno2202
Copy link
Contributor

@narno2202 narno2202 commented Aug 24, 2024

Description

As the 2 workaround found, are far away from universal. Disable FT_MOTION for homing and probing when a Biqu Microprobe V1 or V2 is present.

Requirements

Benefits

Allow more printers to use FTM and Biqu Microprobe

Configurations

Related Issues

Need feedback and test

#if ENABLED(FT_MOTION) && DISABLED(ENDSTOP_INTERRUPTS_FEATURE)
#error "BIQU Microprobe requires ENDSTOP_INTERRUPTS_FEATURE with FT_MOTION."
#if ENABLED(FT_MOTION) && DISABLED(ENDSTOP_INTERRUPTS_FEATURE) && !(Z_CURRENT_HOME < Z_CURRENT)
#error "BIQU Microprobe requires ENDSTOP_INTERRUPTS_FEATURE or Z_CURRENT_HOME lower than Z_CURRENT with FT_MOTION."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be fixing the actual issue instead of adding more sanity checks/workarounds.

@narno2202
Copy link
Contributor Author

@thisiskeithb ,
I totally agree, but for now I just found those two workarounds to use Biqu Micorprobre with FTM. Do you have the possibility to test this probe? I found strange to solve the failure by lowering the Z motor current : hardware related?.

@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 30, 2024

After some testing with a BIQU Hurakan (Manta M4P, TMC2209s, MicroProbe V2) using 3d7ac16, here's what I found:

Enabling or disabling ENDSTOP_INTERRUPTS_FEATURE with FT_MOTION enabled still causes immediate probe trigger as Z homing starts & causes homing to fail.

Halving Z homing current from 800mA down to 400mA (even testing down to below 300mA), with or without ENDSTOP_INTERRUPTS_FEATUREstill causes immediate probe trigger as Z homing starts & causes homing to fail with FT_MOTION enabled.

There are no homing or probing failures (with or without ENDSTOP_INTERRUPTS_FEATURE) with FT_MOTION disabled or not compiled in.

This sanity check is not a fix and should be removed / moved to FT Motion's docs as a possible troubleshooting step and not a strict requirement:

#if ENABLED(FT_MOTION) && DISABLED(ENDSTOP_INTERRUPTS_FEATURE)
#error "BIQU Microprobe requires ENDSTOP_INTERRUPTS_FEATURE with FT_MOTION."
#endif

Same goes for the changes introduced in this PR. Neither work for my hardware.

More testing needs to be done on wider hardware so we don't end up with overbearing sanity checks or better yet, do as I suggested in #27302 (comment) and temporarily disable FT_MOTION during homing/probing.

@narno2202 narno2202 changed the title FT_MOTION: Biqu Microprobe follow up FT_MOTION: Disable FT-MOTION for homing and probing for Biqu Microprobe Sep 1, 2024
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants