-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup of comments/spacing #27231
Open
classicrocker883
wants to merge
13
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
classicrocker883:bugfix-2.1.x-July1
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Major cleanup of comments/spacing #27231
classicrocker883
wants to merge
13
commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-July1
+882
−713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classicrocker883
changed the title
Update src/feature files
Update src/feature + src/module files
Jul 2, 2024
classicrocker883
changed the title
Update src/feature + src/module files
Major cleanup of comments/spacing
Jul 13, 2024
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
August 12, 2024 01:01
c792921
to
37fb26b
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
September 28, 2024 01:10
37d77d6
to
aa44542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most important take away from this:
The majority of changes to src/[module+feature] adds missing header to these files.
example:
as well as:
(mm)
)Other Major changes
Spacing and Cleanup HAL/DUE/usb + sd/usb_flashdrive files
for example:
/*
=>/**
#endif /* [insert] */
=>#endif // [insert]
TO-DO
/to-do
=>TODO:
Benefits
Updates the files to be similar like the rest.
Spacing.
Readability, and update some sentences make better sense.
Configurations
Related Issues
other files in src/module could use header with their filename added to them.