Skip to content

Follow up HAL Refractor #23354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkyhead merged 4 commits into from
Dec 26, 2021
Merged

Follow up HAL Refractor #23354

thinkyhead merged 4 commits into from
Dec 26, 2021

Conversation

@robbycandra
Copy link
Contributor

@robbycandra robbycandra commented Dec 26, 2021 •
edited
Loading

FIx conversion from HAL_ANALOG_SELECT to adc_enable
Fix typo at HAL_SPI STM32

This is follow up for #23295 #23352

@thinkyhead
Copy link
Member

thinkyhead commented Dec 26, 2021

Thanks! It amazes me that my typos didn't result in CI errors.

@thinkyhead thinkyhead merged commit a47f559 into MarlinFirmware:bugfix-2.0.x Dec 26, 2021
thinkyhead added a commit that referenced this pull request Dec 26, 2021
@thinkyhead
♻️ Refactor HAL as singleton (#23295, #23354)
75337cc
@robbycandra
Copy link
Contributor Author

robbycandra commented Dec 26, 2021

@thinkyhead, Is there something "unfinished" in the NATIVE_SIM ?

thinkyhead added a commit that referenced this pull request Dec 26, 2021
@thinkyhead
♻️ Refactor HAL as singleton (#23295, #23354)
059ae4d
@robbycandra robbycandra deleted the Follow_Up_HAL branch December 26, 2021 05:32
Foxies-CSTL added a commit to Foxies-CSTL/Marlin_2.1.x that referenced this pull request Dec 26, 2021
@Foxies-CSTL
Squashed commit of the following:
d229168 
commit 1a6dbcb
Merge: eebf187 56ac681
Author: Foxies-CSTL <[email protected]>
Date:   Sun Dec 26 19:02:32 2021 +0100

    Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bugfix-2.0.x

commit 56ac681
Author: Scott Lahteine <[email protected]>
Date:   Sun Dec 26 03:20:29 2021 -0600

    🎨 Pins and SDIO cleanup

commit 7762df7
Author: EvilGremlin <[email protected]>
Date:   Sun Dec 26 09:46:13 2021 +0300

    🔧 Check Chiron LCD requirements (MarlinFirmware#23353)

    Co-Authored-By: EvilGremlin <[email protected]>

commit 6a8b927
Author: Scott Lahteine <[email protected]>
Date:   Sat Dec 25 23:15:17 2021 -0600

    ⏪️ Refactor still needs work

    Reverting MarlinFirmware#23295

commit 00e6e90
Author: Scott Lahteine <[email protected]>
Date:   Sat Dec 25 22:10:47 2021 -0600

    🐛 Fix adc_start for AVR, native

    Followup to MarlinFirmware#23295

commit 555c749
Author: Keith Bennett <[email protected]>
Date:   Sat Dec 25 19:41:01 2021 -0800

    🐛 Fix MKS Robin E3 NeoPixel pin default (MarlinFirmware#23350)

commit a47f559
Author: Robby Candra <[email protected]>
Date:   Sun Dec 26 10:36:09 2021 +0700

    🐛 HAL refactor followup (MarlinFirmware#23354)

commit 57315f0
Author: Scott Lahteine <[email protected]>
Date:   Sat Dec 25 21:25:47 2021 -0600

    🐛 Fix missing ADC method

commit d7af619
Author: kaidegit <[email protected]>
Date:   Sun Dec 26 10:12:20 2021 +0800

    🐛 Fix open for bin rename (MarlinFirmware#23351)

commit 4f0932e
Author: Scott Lahteine <[email protected]>
Date:   Sat Dec 25 20:00:48 2021 -0600

    🐛 Fix `freeMemory` endless loop

    Followup to MarlinFirmware#23295

commit bdb0716
Author: thinkyhead <[email protected]>
Date:   Sun Dec 26 01:09:46 2021 +0000

    [cron] Bump distribution date (2021-12-26)

commit fca6d12
Author: Scott Lahteine <[email protected]>
Date:   Sat Dec 25 03:27:45 2021 -0600

    🔧 Move MOTHERBOARD closer to top

commit c74161c
Author: fflosi <[email protected]>
Date:   Sat Dec 25 05:57:07 2021 -0300

    ✨ Per-axis TMC hold multiplier (MarlinFirmware#23345)

commit a941cd3
Author: Scott Lahteine <[email protected]>
Date:   Fri Dec 24 23:47:52 2021 -0600

    🔨 Configurable firmware bin filename

    Configuration.h > FIRMWARE_BIN

commit e211ff1
Author: Scott Lahteine <[email protected]>
Date:   Fri Dec 24 21:33:59 2021 -0600

    ♻️ Refactor HAL as singleton (MarlinFirmware#23295)

commit 532f21f
Author: Scott Lahteine <[email protected]>
Date:   Fri Dec 24 21:32:00 2021 -0600

    🔨 Ignore sublime workspace file

commit cd1920b
Author: Scott Lahteine <[email protected]>
Date:   Fri Dec 24 20:59:28 2021 -0600

    🔨 Ignore cmake generated build folder

commit 6d09d1d
Author: thinkyhead <[email protected]>
Date:   Sat Dec 25 01:04:01 2021 +0000

    [cron] Bump distribution date (2021-12-25)

commit d5dff19
Author: Scott Lahteine <[email protected]>
Date:   Fri Dec 24 01:46:51 2021 -0600

    🔧 Sanity check MMU2_MENUS

commit 21cd715
Author: Sola <[email protected]>
Date:   Fri Dec 24 14:03:32 2021 +0800

    ✨ MKS TinyBee board support (MarlinFirmware#23340)

    Co-Authored-By: Sola <[email protected]>

commit 80a537c
Author: Attila BODY <[email protected]>
Date:   Fri Dec 24 06:57:20 2021 +0100

    🐛 Fix Robin Nano v3 filament runout pins (MarlinFirmware#23344)

    Co-authored-by: Scott Lahteine <[email protected]>

commit ca0215b
Author: thinkyhead <[email protected]>
Date:   Fri Dec 24 01:04:40 2021 +0000

    [cron] Bump distribution date (2021-12-24)

commit df9eb56
Author: MrAlvin <[email protected]>
Date:   Thu Dec 23 10:47:52 2021 +0100

    🚸 Show mm'ss during first hour (MarlinFirmware#23335)

    Co-authored-by: Scott Lahteine <[email protected]>

commit 3e737cb
Author: Robby Candra <[email protected]>
Date:   Thu Dec 23 15:19:39 2021 +0700

    🔧 Group FAST_PWM_FAN.options (MarlinFirmware#23331)

    Co-authored-by: Scott Lahteine <[email protected]>

commit da67deb
Author: Tanguy Pruvot <[email protected]>
Date:   Thu Dec 23 08:32:27 2021 +0100

    ✏️ Fix missing brace (MarlinFirmware#23337)

    Followup to MarlinFirmware#22916

    Co-authored-by: Scott Lahteine <[email protected]>

commit 1b876c1
Author: Tanguy Pruvot <[email protected]>
Date:   Thu Dec 23 07:49:15 2021 +0100

    🩹 Fix settings G21 report (MarlinFirmware#23338)

commit c80ef71
Author: thinkyhead <[email protected]>
Date:   Thu Dec 23 01:05:31 2021 +0000

    [cron] Bump distribution date (2021-12-23)

commit 2893048
Author: InsanityAutomation <[email protected]>
Date:   Tue Dec 21 23:09:55 2021 -0500

    ✨ BLTouch High Speed mode runtime configuration (MarlinFirmware#22916)

    Co-authored-by: Scott Lahteine <[email protected]>

commit c1dba3d
Author: ellensp <[email protected]>
Date:   Wed Dec 22 15:44:04 2021 +1300

    ✨ Option to reset EEPROM on first run (MarlinFirmware#23276)

    Co-authored-by: Scott Lahteine <[email protected]>

commit fdd37a8
Author: thinkyhead <[email protected]>
Date:   Wed Dec 22 01:07:10 2021 +0000

    [cron] Bump distribution date (2021-12-22)

commit 9cee626
Author: ellensp <[email protected]>
Date:   Wed Dec 22 13:48:38 2021 +1300

    🐛 Fix Chitu Z_STOP_PIN (MarlinFirmware#23330)

commit f374fa0
Author: Mike La Spina <[email protected]>
Date:   Tue Dec 21 01:26:31 2021 -0600

    🚑️ FAST_PWM_FAN default 1KHz base freq. (MarlinFirmware#23326)

    Co-authored-by: Scott Lahteine <[email protected]>

commit b06f871
Author: thinkyhead <[email protected]>
Date:   Tue Dec 21 01:08:00 2021 +0000

    [cron] Bump distribution date (2021-12-21)
mh-dm pushed a commit to mh-dm/Marlin that referenced this pull request May 15, 2022
@robbycandra @mh-dm
🐛 HAL refactor followup (MarlinFirmware#23354)
a9108a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robbycandra @thinkyhead