Skip to content

Conversation

@luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 20, 2021

Description

Fix typo in source. Change has not been tested.

Benefits

Self-explanatory

@ellensp
Copy link
Contributor

ellensp commented Nov 20, 2021

You cannot do this without updating all references to TotalHeigh In Arduino_Core_STM32
Eg it is defined as
uint32_t TotalHeigh; /*!< configures the total height.
In Arduino_Core_STM32
https://github.com/stm32duino/Arduino_Core_STM32/blob/main/system/Drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_ltdc.h#L103

Marlin will not compile with this change when this code is included.

@ellensp ellensp added the S: Don't Merge Work in progress or under discussion. label Nov 20, 2021
@tpruvot
Copy link
Contributor

tpruvot commented Nov 20, 2021

well wait, you pointed main branch but we are not on it...
1.9 is closer to codeql branch (legacy branch)
https://github.com/stm32duino/Arduino_Core_STM32/blob/codeql/system/Drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_ltdc.h#L146

@tpruvot
Copy link
Contributor

tpruvot commented Nov 20, 2021

@ellensp
Copy link
Contributor

ellensp commented Nov 20, 2021

Test procedure. Set the following
platfomio.ini
default_envs = BTT_SKR_SE_BX

Configuration.h
#define SERIAL_PORT -1
#define MOTHERBOARD BOARD_BTT_SKR_SE_BX
#define BIQU_BX_TFT70
#define TFT_CLASSIC_UI

Applying this PR results in this error.

Marlin/src/HAL/STM32/tft/tft_ltdc.cpp: In function 'void LTDC_Config()':
Marlin/src/HAL/STM32/tft/tft_ltdc.cpp:186:16: error: 'struct LTDC_InitTypeDef' has no member named 'TotalHeight'; did you mean 'TotalHeigh'?
  186 |   hltdc_F.Init.TotalHeight = (TFT_HEIGHT + LTDC_LCD_VSYNC + LTDC_LCD_VBP + LTDC_LCD_VFP - 1);
      |                ^~~~~~~~~~~
      |                TotalHeigh
*** [.pio/build/BTT_SKR_SE_BX/src/src/HAL/STM32/tft/tft_ltdc.cpp.o] Error 1

@thisiskeithb
Copy link
Member

This was "fixed" once before in #22531 and I reverrted it in #22776.

Perhaps we need comments on these types of variables to prevent them from being caught up in spell check PRs.

@thisiskeithb
Copy link
Member

default_envs = BTT_SKR_SE_BX

We also have a standard BX config now, so perhaps our CI test should be updated (it would have caught this).

@ellensp
Copy link
Contributor

ellensp commented Nov 20, 2021

@thisiskeithb looking at luzpaz GitHub, this seems to be a mostly automated system for finding spelling errors in code.
So comments may not help, but a CI test will stop this occurring again...

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 20, 2021

I'll submit typo fixes to the upstream repo: https://github.com/stm32duino/Arduino_Core_STM32.git
There are so many typos in the source (currently at 723 files and still not done)

@luzpaz luzpaz closed this Nov 20, 2021
@luzpaz luzpaz deleted the source-typo branch November 21, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S: Don't Merge Work in progress or under discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants