-
-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix source typo #23161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source typo #23161
Conversation
|
You cannot do this without updating all references to TotalHeigh In Arduino_Core_STM32 Marlin will not compile with this change when this code is included. |
|
well wait, you pointed main branch but we are not on it... |
|
nevermind, i linked bad line/var.. https://github.com/stm32duino/Arduino_Core_STM32/blob/codeql/system/Drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_ltdc.h#L103 yea :p |
|
Test procedure. Set the following Configuration.h Applying this PR results in this error. Marlin/src/HAL/STM32/tft/tft_ltdc.cpp: In function 'void LTDC_Config()':
Marlin/src/HAL/STM32/tft/tft_ltdc.cpp:186:16: error: 'struct LTDC_InitTypeDef' has no member named 'TotalHeight'; did you mean 'TotalHeigh'?
186 | hltdc_F.Init.TotalHeight = (TFT_HEIGHT + LTDC_LCD_VSYNC + LTDC_LCD_VBP + LTDC_LCD_VFP - 1);
| ^~~~~~~~~~~
| TotalHeigh
*** [.pio/build/BTT_SKR_SE_BX/src/src/HAL/STM32/tft/tft_ltdc.cpp.o] Error 1
|
We also have a standard BX config now, so perhaps our CI test should be updated (it would have caught this). |
|
@thisiskeithb looking at luzpaz GitHub, this seems to be a mostly automated system for finding spelling errors in code. |
|
I'll submit typo fixes to the upstream repo: https://github.com/stm32duino/Arduino_Core_STM32.git |
Description
Fix typo in source. Change has not been tested.
Benefits
Self-explanatory