Non Intrusive Warning for MARLIN_DEV_MODE #19163
Conversation
#19069 this is the one I'm aware of |
One complain? Anyway, I don't think we must annoy the devs. Sure the dev could comment that warning line, but do they will do it? If they don't, it will hides real warning, and we may get more and more warnings soon. I changed to add to the status screen the message. For a user, I think it will be enough. |
|
I think it's the only one since DEV_MODE, but you asked ;-) |
|
The commit that added |
rhapsodyv
changed the title
Or just comment out the check while developing. |
Sure the dev could comment that warning line, but do they will do it? If they don't, it will hides real warning, and we may get more and more warnings soon. |
…K8800-2.0.x * tag '2.0.6.1' of https://github.com/MarlinFirmware/Marlin: (195 commits) Version 2.0.6.1 [cron] Bump distribution date (2020-08-28) Add set_all_homed Mark axes not-homed with HOME_AFTER_DEACTIVATE (MarlinFirmware#18907) set_axis_not_trusted => set_axis_never_homed Independent Neopixel option (MarlinFirmware#19115) Fix Creality V4 probe pin Fix small typø Allocate sufficient MSG_MOVE_Z_DIST buffer One MARLIN_DEV_MODE warning per rebuild (MarlinFirmware#19163) FYSETC S6 2.0 (MarlinFirmware#19140) [cron] Bump distribution date (2020-08-27) Fix SINGLENOZZLE fan speed bug (MarlinFirmware#19152) Fix NEOPIXEL_STARTUP_TEST last delay (MarlinFirmware#19156) TFT (plus Hardware SPI) for LPC (MarlinFirmware#19139) Prusa => Průša Direct Stepping update (MarlinFirmware#19135) Fixes to FTDI Touch UI (MarlinFirmware#19134) Add Einsy Rambo Filament Runout Pin (MarlinFirmware#19136) Fix SD pins for SKR Pro and GTR (MarlinFirmware#19047) ...
4 participants
Description
Recently it was added a message to warning the user to disable MARLIN_DEV_MODE in production.
But it really annoy, disturb and confuse, when we are working in marlin with that option enabled.
As developers, one of your goals is to have a code completly free from erros and warnings.
And it's generating tons of warnings. That tends to confuse devs and soon will have more and more warnings of other types hidden in the middle of those of marlin dev mode....
Is there too many complains by users forgetting it enabled?
If so, we can work in a non intrusive option, like show a message in the marlin status screen.... It will warn the user, but it will not be annoying while working on marlin.