Hotend Idle Timeout fixes #18032
Merged
Hotend Idle Timeout fixes #18032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use MIN_TO_MS instead of SEC_TO_MS and rename "duration" variable.
Member
Author
|
I'm fine with the changes, but why is it preferred to use |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
Co-authored-by: Scott Lahteine <[email protected]>
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Scott Lahteine <[email protected]>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Scott Lahteine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
HOTEND_IDLE_TIMEOUTDescription
Use
MIN_TO_MSinstead ofSEC_TO_MSand rename "duration" variable.Benefits
Instead of X seconds, duration will be X minutes.
Related Issues
None, but see comments from 213d4b8.