Skip to content

Conversation

@thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 18, 2020

Description

The BigTreeTech GTR ships with a real/onboard EEPROM, so this PR enables it by default. Based on GTR pin file from the official GTR repo.

I bench tested a GTR with these changes and EEPROM settings were saved/retrieved/reset successfully, but it has been reported to work successfully in the GTR Facebook group as well.

Also: #undef E2END was used, otherwise there'd be a ton of redefined warnings.

Benefits

Use onboard/real EEPROM on the GTR.

Related Issues

@thinkyhead
Copy link
Member

I'm working on replacing use of E2END with EEPROM_SIZE. Then the E2END eeprom size from the platform will just be the final fallback. This way we won't have to #undef E2END anywhere. Should be ready soon…

@thinkyhead thinkyhead merged commit 4e51240 into MarlinFirmware:bugfix-2.0.x May 20, 2020
@thisiskeithb thisiskeithb deleted the pr/fix_btt_gtr_eeprom branch May 20, 2020 20:57
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants