Skip to content

Conversation

@sjasonsmith
Copy link
Contributor

Description

This change weakens some assumptions that code was using, to decide when to compile in specific features and variables.

Incorrect assumptions this removes:

  1. PIDTEMPBED implies PIDTEMP
  2. THERMAL_PROTECTION_BED implies THERMAL_PROTECTION_HOTENDS

Aside from errors due to undefined variables/constants, this also prevented several PID-related features from being usable if PID is only used for the bed.

Unfortunately resolving this requires some rearranging to the configuration file, so that these options appear after selection of both types of PID.

Benefits

Allows more freedom when mixing and matching PID and thermal protection features.

Related Issues

#18012 - Must enable THERMAL_PROTECTION_HOTENDS to compile thermal protection code

@sjasonsmith
Copy link
Contributor Author

I am hoping @mobilinkd will be able to try this out, since it should resolve the issue they reported.

@thinkyhead
Copy link
Member

thinkyhead commented May 18, 2020

With these changes, the heater watch will only function if the PIDTEMP options are enabled. But the heater watch should work for all forms of heaters. All it does is wait for the temperature to stick close to the target for a defined period.

@thinkyhead
Copy link
Member

Huh. On review I see that that was the old logic too. Hmm… I'll have to go back and see why is is necessary to have PID enabled. I'm guessing that it's watching the raw PID values.

@sjasonsmith
Copy link
Contributor Author

I think it is just that these changes are in the PID tuning code. You will only ever be in that code for a heater with PID enabled.

@thinkyhead
Copy link
Member

Ah, mais bien sur!

@thinkyhead thinkyhead merged commit 94063e3 into MarlinFirmware:bugfix-2.0.x May 18, 2020
@sjasonsmith sjasonsmith deleted the PR/18012 branch May 25, 2020 22:29
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants