Fix failing combinations of PID and Thermal Protection #18023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change weakens some assumptions that code was using, to decide when to compile in specific features and variables.
Incorrect assumptions this removes:
PIDTEMPBEDimpliesPIDTEMPTHERMAL_PROTECTION_BEDimpliesTHERMAL_PROTECTION_HOTENDSAside from errors due to undefined variables/constants, this also prevented several PID-related features from being usable if PID is only used for the bed.
Unfortunately resolving this requires some rearranging to the configuration file, so that these options appear after selection of both types of PID.
Benefits
Allows more freedom when mixing and matching PID and thermal protection features.
Related Issues
#18012 - Must enable THERMAL_PROTECTION_HOTENDS to compile thermal protection code