Prevent some macro pitfalls#17956
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom May 12, 2020
espr14:patch-2
Merged
Prevent some macro pitfalls#17956thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom espr14:patch-2
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
espr14:patch-2
Conversation
Co-Authored-By: espr14 <espr14@users.noreply.github.com>
Member
|
Unfortunately, some of these macros need to function in the preprocessor. |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
Co-authored-by: espr14 <espr14@users.noreply.github.com>
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: espr14 <espr14@users.noreply.github.com>
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
Co-authored-by: espr14 <espr14@users.noreply.github.com>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: espr14 <espr14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you call an argument in macro more than once it could cause side effect due to calling function that change global state like n++. Evaluating these functions at beginning solves the issue.
Benefits
Makes macros safe to be called with a function as an argument.