Fix M261, i2c EEPROM, i2c Encoder for LPC#17678
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom Apr 25, 2020
randellhodges:lpc_m261
Merged
Fix M261, i2c EEPROM, i2c Encoder for LPC#17678thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom randellhodges:lpc_m261
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
randellhodges:lpc_m261
Conversation
Member
|
I've also applied |
thinkyhead
changed the title
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The LPC framework Wire implementation right shifts the I2C address in requestFrom and inside endTransmission.
The I2C_ADDRESS macro left shifts it before calling the wire methods that right shifts it.
It was already doing it inside beginTransmission (which just holds it until endTransmission was called). It just wasn't doing it for requestFrom.
Benefits
Makes M261 great again
Related Issues
#15754
#17677