M125: Deretract same amount as retracted#17623
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Apr 20, 2020
Merged
M125: Deretract same amount as retracted#17623thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When user overrides retract length in M125, amount of deretraction after print resume is different (always PAUSE_PARK_RETRACT_LENGTH).
Currently gcode works this way:
M125: retract=PAUSE_PARK_RETRACT_LENGTH, deretract=PAUSE_PARK_RETRACT_LENGTH
M125 L10: retract=10, deretract=PAUSE_PARK_RETRACT_LENGTH
After fix:
M125 L10: retract=10, deretract=10
Benefits
Deretract amount should be same as retract amount.
Related Issues
none