SKR Pro V1.1 StallGuard pins#17550
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom Apr 15, 2020
Merged
Conversation
In SKR Pro V1.1 the DIAG1 pin of stepper drivers is internally wired to MIN endstops. Delta printers however require homing to MAX. This commit swaps MIN and MAX endstop pins for SKR Pro V1.1 if DELTA is selected and StallGuard is in use. The latter is considered true if any StallGuard-capable stepper is configured for any axis. Resolves bigtreetech/BIGTREETECH-SKR-PRO-V1.1#103 Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Contributor
|
The SKR 1.3 & 1.4 did something similar to remap StallGuard pins: Marlin/Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_4.h Lines 57 to 80 in c834b31 |
Member
|
I've updated this with the standard handling. This causes Marlin to choose the appropriate DIAG pin whenever StallGuard is used on an axis, whether that's min or max. And then the "other" endstop pin for that axis is swapped over, so it can be referenced at some later points under the "other endstop" name. At this time we don't have a concept of E endstops, so those are just assigned to the other XYZ. |
thinkyhead
added a commit
that referenced
this pull request
Apr 15, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
ghost
pushed a commit
to bfhobbes/Marlin
that referenced
this pull request
Apr 15, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SKR Pro V1.1 the DIAG1 pin of stepper drivers
is internally wired to MIN endstops.
Delta printers however require homing to MAX.
This commit swaps MIN and MAX endstop pins for SKR Pro V1.1
if DELTA is selected and StallGuard is in use. The latter
is considered true if any StallGuard-capable stepper
is configured for any axis.
Resolves bigtreetech/BIGTREETECH-SKR-PRO-V1.1#103