Skip to content

SKR Pro V1.1 StallGuard pins#17550

Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
AlexanderAmelkin:bugfix/bigtreetech-skr-pro-v1-1-103
Apr 15, 2020
Merged

SKR Pro V1.1 StallGuard pins#17550
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
AlexanderAmelkin:bugfix/bigtreetech-skr-pro-v1-1-103

Conversation

@AlexanderAmelkin
Copy link
Contributor

In SKR Pro V1.1 the DIAG1 pin of stepper drivers
is internally wired to MIN endstops.
Delta printers however require homing to MAX.
This commit swaps MIN and MAX endstop pins for SKR Pro V1.1
if DELTA is selected and StallGuard is in use. The latter
is considered true if any StallGuard-capable stepper
is configured for any axis.

Resolves bigtreetech/BIGTREETECH-SKR-PRO-V1.1#103

In SKR Pro V1.1 the DIAG1 pin of stepper drivers
is internally wired to MIN endstops.
Delta printers however require homing to MAX.
This commit swaps MIN and MAX endstop pins for SKR Pro V1.1
if DELTA is selected and StallGuard is in use. The latter
is considered true if any StallGuard-capable stepper
is configured for any axis.

Resolves bigtreetech/BIGTREETECH-SKR-PRO-V1.1#103

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
@thisiskeithb
Copy link
Contributor

The SKR 1.3 & 1.4 did something similar to remap StallGuard pins:

//
// Limit Switches
//
#if X_STALL_SENSITIVITY
#define X_STOP_PIN X_DIAG_PIN
#if X_HOME_DIR < 0
#define X_MAX_PIN P1_26 // E0DET
#else
#define X_MIN_PIN P1_26 // E0DET
#endif
#else
#define X_STOP_PIN P1_29 // X-STOP
#endif
#if Y_STALL_SENSITIVITY
#define Y_STOP_PIN Y_DIAG_PIN
#if Y_HOME_DIR < 0
#define Y_MAX_PIN P1_25 // E1DET
#else
#define Y_MIN_PIN P1_25 // E1DET
#endif
#else
#define Y_STOP_PIN P1_28 // Y-STOP
#endif

@thinkyhead
Copy link
Member

I've updated this with the standard handling. This causes Marlin to choose the appropriate DIAG pin whenever StallGuard is used on an axis, whether that's min or max. And then the "other" endstop pin for that axis is swapped over, so it can be referenced at some later points under the "other endstop" name. At this time we don't have a concept of E endstops, so those are just assigned to the other XYZ.

@thinkyhead thinkyhead merged this pull request into MarlinFirmware:bugfix-2.0.x Apr 15, 2020
@thinkyhead thinkyhead changed the title Fix StallGuard for SKR Pro V1.1 in Delta mode SKR Pro V1.1 StallGuard pins Apr 15, 2020
thinkyhead added a commit that referenced this pull request Apr 15, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
ghost pushed a commit to bfhobbes/Marlin that referenced this pull request Apr 15, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments