Add ExtUI::onStatusChanged_P function#17543
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Apr 16, 2020
Merged
Add ExtUI::onStatusChanged_P function#17543thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
It copies the parameter to SRAM and passes it to ExtUI::onStatusChanged (similar to ExtUI::onUserConfirmRequired_P). The call to ExtUI::onStatusChanged in `pause.cpp` was passing a PROGMEM pointer in place of an SRAM one. It's now using ExtUI::onStatusChanged_P.
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It copies its parameter to SRAM and passes it to
ExtUI::onStatusChanged(similarto
ExtUI::onUserConfirmRequired_P).The call to
ExtUI::onStatusChangedinpause.cppwas passing a PROGMEM pointerin place of an SRAM one. It's now using
ExtUI::onStatusChanged_P.