Skip to content

Comments

Fix framework-arduinoststm32 minimum version#17512

Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
sjasonsmith:17495_Fix_STM32_Framework_Dep
Apr 16, 2020
Merged

Fix framework-arduinoststm32 minimum version#17512
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
sjasonsmith:17495_Fix_STM32_Framework_Dep

Conversation

@sjasonsmith
Copy link
Contributor

Description

The minimum version specified for framework-arduinoststm32 allowed stale versions to be used. This is because we specified three digits in the minor version (3.107), but they actually specify 5 (3.10700). This allowed old versions such as 3.10601 to be used, because 10601 > 107.

Benefits

Helps avoid stale framework versions being used.

Related Issues

I'm not sure whether this is the only cause of issues for #17495, but that is how I became aware of this.

@tpruvot
Copy link
Contributor

tpruvot commented Apr 13, 2020

I dont think this is the problem, or maybe it was resolved elsewhere... BIGTREE_SKR_PRO was ok

@tpruvot
Copy link
Contributor

tpruvot commented Apr 13, 2020

well, weird, but that fixes the STM32F407VE_black indeed

@sjasonsmith
Copy link
Contributor Author

I dont think this is the problem, or maybe it was resolved elsewhere... BIGTREE_SKR_PRO was ok

It also built fine for me, but I already had 3.10700 on my system. You can tell from the screenshot in the referenced issue that it was using files from an older version of the framework, even though the minimum was specified as 3.107.

@sjasonsmith
Copy link
Contributor Author

well, weird, but that fixes the STM32F407VE_black indeed

Is there an issue open for that board impacted by this?

@tpruvot
Copy link
Contributor

tpruvot commented Apr 14, 2020 via email

@thinkyhead thinkyhead merged commit 7d0ea3e into MarlinFirmware:bugfix-2.0.x Apr 16, 2020
@sjasonsmith sjasonsmith deleted the 17495_Fix_STM32_Framework_Dep branch May 10, 2020 05:17
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants