Fix framework-arduinoststm32 minimum version#17512
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Apr 16, 2020
Merged
Fix framework-arduinoststm32 minimum version#17512thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Contributor
|
I dont think this is the problem, or maybe it was resolved elsewhere... BIGTREE_SKR_PRO was ok |
Contributor
|
well, weird, but that fixes the STM32F407VE_black indeed |
Contributor
Author
It also built fine for me, but I already had 3.10700 on my system. You can tell from the screenshot in the referenced issue that it was using files from an older version of the framework, even though the minimum was specified as 3.107. |
Contributor
Author
Is there an issue open for that board impacted by this? |
Contributor
|
I don't think so, this board is a tiny/cheap dev/arduino kit... but was in
my travis (old marlin one)
Le lun. 13 avr. 2020 à 15:48, Jason Smith <notifications@github.com> a
écrit :
… well, weird, but that fixes the STM32F407VE_black indeed
Is there an issue open for that board impacted by this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDNXYQM7BP242N3CTS3ZLRMMJ4PANCNFSM4MGYG2EA>
.
|
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The minimum version specified for framework-arduinoststm32 allowed stale versions to be used. This is because we specified three digits in the minor version (3.107), but they actually specify 5 (3.10700). This allowed old versions such as 3.10601 to be used, because 10601 > 107.
Benefits
Helps avoid stale framework versions being used.
Related Issues
I'm not sure whether this is the only cause of issues for #17495, but that is how I became aware of this.