[1.1.x] Fix G29 Z position after bilinear ABL with fade height#17174
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom Mar 15, 2020
Merged
Conversation
Change to G29 code in marlin_main.cpp. Fixes issue where Z position is incorrect after bilinear ABL with fade height enabled. Tested on Ender 3 with BLTouch.
Member
|
Good catch, thanks! |
thinkyhead
pushed a commit
that referenced
this pull request
Mar 15, 2020
thinkyhead
changed the title
Contributor
Author
|
Thanks! Glad I could help! |
RepairSyl
added a commit
to RepairSyl/Marlin
that referenced
this pull request
Mar 17, 2020
Fix Z position after ABL bilinear G29 with fade (MarlinFirmware#17174)
TiagoJustino
added a commit
to TiagoJustino/Marlin
that referenced
this pull request
Apr 2, 2020
* MarlinFirmware/1.1.x: (133 commits) Fix Z position after ABL bilinear G29 with fade (MarlinFirmware#17174) Change DUMMY_PID_VALUE to NAN (MarlinFirmware#17079) Disable integration testing Enable DUAL_NOZZLE_DUPLICATION_MODE (MarlinFirmware#16436) [1.1.x] Polish language UTF8 (MarlinFirmware#16141) Links for the "New Issue" page Add Korean language (MarlinFirmware#15918) [1.1.x] MKS_GEN_L_V2 controller (MarlinFirmware#15805) Update bug_report.md [1.1.x] Fix autostart w/out SD_DETECT_PIN (MarlinFirmware#15667) [1.1.x] RAMPS + Viki1 LCD compatibility (MarlinFirmware#15736) [1.1.x] Fix compiler warning (MarlinFirmware#15642) [1.1.x] Fix for G2/G3 rounding error (MarlinFirmware#15546) Let MINIPANEL use SW SPI if needed (MarlinFirmware#15246) Fix BLTouch debugging (MarlinFirmware#15232) Fix Creality bed thermistor Fix PT-BR strings (MarlinFirmware#15023) Fix #else extra tokens (MarlinFirmware#15013) [1.1.x] Autobuild formatting (MarlinFirmware#14858) [1.1.x] BLTouch 3.0 - 3.1 (MarlinFirmware#14839) ...
maz3max
pushed a commit
to maz3max/Marlin
that referenced
this pull request
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After doing a G29 bed leveling using bilinear ABL with fade height enabled and a non-zero value the current Z position is incorrect. This causes inconsistent bed leveling results.
The bilinear_z_offset is subtracted from the current Z position at the end of G29. It is expected that it will be added back in planner.apply_leveling. However the fade_scaling_factor is not taken into consideration for the subtraction in G29. If fade height is a non-zero value the resulting Z position will be incorrect.
This change takes the fade_scaling_factor into account when subtracting the bilinear offset in G29.
I have tested the change on my Ender 3 with a BLTouch under different scenarios and it fixes the issue.
Benefits
Fixes the incorrect Z position after bilinear ABL when using fade height.
Related Issues
Fixes bug as described in issue #17166.