Fix G76 reachable test#17005
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom Feb 28, 2020
Merged
Conversation
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
from
2f39240 to
232ba42
Compare
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
4 times, most recently
from
9f0ed6f to
1b3b049
Compare
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
from
1b3b049 to
adb80a7
Compare
TheNeskik
suggested changes
Feb 27, 2020
TheNeskik
reviewed
Feb 27, 2020
TheNeskik
reviewed
Feb 27, 2020
TheNeskik
reviewed
Feb 27, 2020
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
from
c178dbb to
bf71afc
Compare
Member
Author
|
@TheNeskik — When a test is obviously failing from a typo, and the contributor is off having dinner, there is no need to SPAM the PR about it. We can see compile errors right here on this page already. |
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
2 times, most recently
from
8dd1bd1 to
4ed3099
Compare
thinkyhead
force-pushed
the
bf2_fix_g76_check_PR
branch
from
4ed3099 to
f0cefb2
Compare
oechslein
pushed a commit
to oechslein/Marlin
that referenced
this pull request
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #16995
The
position_is_reachable_by_probefunction accounts for the probe offset, so we just need to pass the position without subtracting the offset.Also: The
G76code needed to go on a diet. Much bloat has been removed.