Skip to content

Fix #16619, SKR 1.3 swaps MIN and MAX endstops if homing to max. #16659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkyhead merged 2 commits into from
Jan 26, 2020
Merged

Fix #16619, SKR 1.3 swaps MIN and MAX endstops if homing to max. #16659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca1072
Fix #16619
Jan 23, 2020
20eb4a5
Update pins_BTT_SKR_V1_3.h
thinkyhead Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,31 @@

/**
* Limit Switches
*
* For Stallguard homing to max swap the min / max pins so
* the MAX physical connectors can be used for other things.
*/
#if X_HOME_DIR == -1 || !X_STALL_SENSITIVITY
#if X_HOME_DIR > 0 && X_STALL_SENSITIVITY && !defined(USE_XMAX_PLUG)
// For StallGuard homing to MAX swap the MIN / MAX pins
// so the MAX physical connectors may be used for other things.
#define X_MIN_PIN P1_28 // X_MAX (free)
#define X_MAX_PIN P1_29 // X_MIN
#else // else, non-endstop is free and appears in M43 output
#define X_MIN_PIN P1_29 // X_MIN
#define X_MAX_PIN P1_28 // X_MAX
#else
#define X_MIN_PIN P1_28 // X_MAX
#define X_MAX_PIN P1_29 // X_MIN
#endif

#if Y_HOME_DIR == -1 || !Y_STALL_SENSITIVITY
#if Y_HOME_DIR > 0 && Y_STALL_SENSITIVITY && !defined(USE_YMAX_PLUG)
#define Y_MIN_PIN P1_26 // Y_MAX (free)
#define Y_MAX_PIN P1_27 // Y_MIN
#else
#define Y_MIN_PIN P1_27 // Y_MIN
#define Y_MAX_PIN P1_26 // Y_MAX
#else
#define Y_MIN_PIN P1_26 // Y_MAX
#define Y_MAX_PIN P1_27 // Y_MIN
#endif

#if Z_HOME_DIR == -1 || !Z_STALL_SENSITIVITY
#if Z_HOME_DIR > 0 && Z_STALL_SENSITIVITY && !defined(USE_ZMAX_PLUG)
#define Z_MIN_PIN P1_24 // Z_MAX (free)
#define Z_MAX_PIN P1_25 // Z_MIN
#else
#define Z_MIN_PIN P1_25 // Z_MIN
#define Z_MAX_PIN P1_24 // Z_MAX
#else
#define Z_MIN_PIN P1_24 // Z_MAX
#define Z_MAX_PIN P1_25 // Z_MIN
#endif

#define ONBOARD_ENDSTOPPULLUPS // Board has built-in pullups
Expand Down