Apply soft limits to G2/G3 final target#15156
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Sep 4, 2019
vector76:patch-1
Merged
Apply soft limits to G2/G3 final target#15156thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom vector76:patch-1
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
vector76:patch-1
Conversation
Contributor
Author
|
Ok I've reproduced the bug and tested the proposed remedy. Here is a video showing a simple G2 command where the final position is in negative coordinates. The first two curves are without the fix, first starting from (0, 0), exhibiting the problem, and then starting from within the working volume. The second two curves are with the proposed bugfix, first starting from (0, 0), properly clipping and then starting from within the working volume. All four curves are the same gcode: |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Observed strange behavior when G2/G3 interacts with soft limits. Here is one example: https://www.v1engineering.com/forum/topic/strange-movement/
This strange behavior appears to be due to incorrect application of limits in G2/G3 movements.
Upon examining the code, found that the final movement to reach the target location does not have limits applied (apply_motion_limits).
Benefits
Proper clipping of G2/G3 movements when endpoint is outside working volume.
Related Issues
Unfortunately my machine is down so I can't test it right now. I'll test shortly and update with the findings.