Fix "unqualified id" warning#15144
Conversation
7c999a5 to
2c1c1a0
Compare
2c1c1a0 to
6484ab6
Compare
|
I think this is a case of different warning for different c++ standards and/or gcc versions, this PR introduced a warning (array bounds) in the LPC builds where there was no warnings before, the reinterpret cast approach wasn't causing any warnings but I'd only recently refactored away from the unions so it probably doesn't matter either way. |
|
nevermind (missed that the header is a union). I will just suppress the warning. |
|
Currently trying to finish this (Marlin Binary Protocol) so we don't have to remove it before you release 2.0, can't have people implementing an incomplete standard into things.. I do have it working as a fully binary protocol, (rx and tx) but still need to work around a few things, data lifetime etc, if a packet needs resent it needs to have been buffered somewhere .. memory constraints are a headache as usual. It is nice having a completely non blocking transport layer to work with though, can transfer a file while streaming data and being able to send "instantaneous" commands at the same time. |
|
Memory constraints are always annoying, but there is no substitute. On the positive side, the low-end Melzi boards have an overabundance of RAM. |
GCC doesn't like re-casting between abstract types. This PR uses a
unionto get byte-level access to the data structure.CC: @p3p