Add LCD Contrast menu for Fysetc 12864#15024
Closed
nicpottier wants to merge 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Closed
Add LCD Contrast menu for Fysetc 12864#15024nicpottier wants to merge 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
nicpottier wants to merge 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
It feels more natural for the def to be defined in the the def for the LCD controller instead of this big || block but my first PR so keeping it simple.
Member
|
Check to see if this works first: #15006 |
Author
|
Hah, pulled minutes ago but not late enough! Yes, seems to fix it and in a much better way. Thanks! |
Member
|
Good to hear. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No LCD menu to tweak contrast on the Fysetc 12864 1_2. This seems new as of a few weeks ago. Tracked it down to this OR block and just added that LCD but maybe refactoring
HAS_LCD_CONTRASTto be something defined in the LCD blocks makes more sense?Benefits
You can see things! No but seriously without this on my SKR 1.3 I thought LCD had broken entirely. Contrast tweaking works quite well interactively and the defaults that come with
HAS_LCD_CONTRASTalso seem more appropriate.Related Issues
N/A