Skip to content

Fix Z-move to uninitialized position in SWITCHING_EXTRUDERS tool_change (no_move=true) #12483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkyhead merged 1 commit into from
Nov 20, 2018
Merged

Fix Z-move to uninitialized position in SWITCHING_EXTRUDERS tool_change (no_move=true) #12483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Marlin/src/module/tool_change.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,11 @@
#endif // DO_SWITCH_EXTRUDER

#if ENABLED(SWITCHING_NOZZLE)

void move_nozzle_servo(const uint8_t e) {
planner.synchronize();
MOVE_SERVO(SWITCHING_NOZZLE_SERVO_NR, servo_angles[SWITCHING_NOZZLE_SERVO_NR][e]);
safe_delay(500);
}

#endif // SWITCHING_NOZZLE

#if ENABLED(PARKING_EXTRUDER)
Expand Down Expand Up @@ -594,8 +592,9 @@ void tool_change(const uint8_t tmp_extruder, const float fr_mm_s/*=0.0*/, bool n

#endif

set_destination_from_current();

if (!no_move) {
set_destination_from_current();
#if DISABLED(SWITCHING_NOZZLE)
// Do a small lift to avoid the workpiece in the move back (below)
#if ENABLED(TOOLCHANGE_PARK)
Expand Down