[2.0.x] Simplified pins_TRIGORILLA_14#12162
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom Oct 21, 2018
Merged
[2.0.x] Simplified pins_TRIGORILLA_14#12162thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
brandstaetter
changed the title
Member
|
This kind of makes it difficult to repurpose the MOSFET connectors for other purposes. That was the reason for the conditions. We don’t want to force a board to always be used as EEB just because it happens to come that way in one machine. |
Contributor
Author
|
Even if the board is clearly labeled like that? Okay, then I'll keep the conditions. My main goals are the fan connectors anyway. |
Member
Yes. RepRap enthusiasts don't care about the silkscreen. A MOSFET is a MOSFET is a MOSFET. |
thinkyhead
force-pushed
the
bf2_board_trigorilla_1_4
branch
from
fb646ce to
143508d
Compare
thinkyhead
force-pushed
the
bf2_board_trigorilla_1_4
branch
from
143508d to
abe9e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified pins_TRIGORILLA_14
There was a bit of unnecessary if-elsif-else and a fan pin was not defined (unused for Anycubic Kossel, but otherwise usable)
Pin numbers taken from #11356 (comment) in #11356
Benefits
make a fan pin usable
clean code
Related Issues
N/A