Fix TMC_DEBUG undefined report_tmc_status#11993
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Oct 3, 2018
Merged
Fix TMC_DEBUG undefined report_tmc_status#11993thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Member
|
No it should be under |
Member
Author
|
Well, the flag is only used / settable with #if ENABLED(TMC_DEBUG)
. . .
/**
* M122 report functions
*/
void tmc_set_report_status(const bool status) {
if ((report_tmc_status = status))
SERIAL_ECHOLNPGM("axis:pwm_scale |status_response|");
}
. . .
#endif // TMC_DEBUG
…and… #if ENABLED(TMC_DEBUG)
#include "../../gcode.h"
#include "../../../feature/tmc_util.h"
/**
* M122: Debug TMC drivers
*/
void GcodeSuite::M122() {
if (parser.seen('S'))
tmc_set_report_status(parser.value_bool());
else
tmc_report_all();
}
#endif // TMC_DEBUG |
Member
|
Ah true. Maybe I'll need to revise that once I know what I want to do with the feature. Maybe it should require both config options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #11992
Issue introduced by #11943
The
report_tmc_statusvariable was only defined forMONITOR_DRIVER_STATUS. This PR ensures that the variable is defined based onTMC_DEBUG.Concise Diff