Skip to content

[2.0.x] Extruder-Distinct Linear Advance K Factors#11789

Merged
thinkyhead merged 7 commits intoMarlinFirmware:bugfix-2.0.xfrom
SJ-Innovation:bf2_LinAdv_DistinctKFactor
Sep 11, 2018
Merged

[2.0.x] Extruder-Distinct Linear Advance K Factors#11789
thinkyhead merged 7 commits intoMarlinFirmware:bugfix-2.0.xfrom
SJ-Innovation:bf2_LinAdv_DistinctKFactor

Conversation

@SJ-Innovation
Copy link
Contributor

Linear Advance is often used on Multi-Extruder setups where each extruder uses a different material. Obviously the material properties therefore differ so a different K factor will be required for each extruder.

This also allows the use of LinAdv on one extruder but entirely disabling on others, this is useful for hybrid direct-bowden drives where too high a K factor on the direct drive unit can ruin the print.

This PR adds individual K factors and their required setters on the LCD menus.

@thinkyhead thinkyhead force-pushed the bf2_LinAdv_DistinctKFactor branch 2 times, most recently from d2522b1 to c433e87 Compare September 10, 2018 09:45
@SJ-Innovation
Copy link
Contributor Author

Hi, I keep asking questions i know. Bear with. Sorry.

These formatting corrections you make, do you do them all by hand? Or do you have some form of auto-formatter? I feel awful for making you do such menial corrections should you do them by hand.

If you do use an autoformatter, which do you use? And what setup for it do you use?

Thanks,
Sam :)

@thinkyhead thinkyhead force-pushed the bf2_LinAdv_DistinctKFactor branch from c433e87 to 149cdeb Compare September 10, 2018 09:46
@thinkyhead thinkyhead force-pushed the bf2_LinAdv_DistinctKFactor branch from 149cdeb to 80e30ab Compare September 10, 2018 09:49
@thinkyhead
Copy link
Member

I do it all meticulously by hand, except things like stripping out trailing whitespace or locating tabs, where I will use global search (and replace).

@SJ-Innovation
Copy link
Contributor Author

Fair enough, I'll make a concerted effort to minimise your correction load in future then!

@thinkyhead
Copy link
Member

Appreciated! Just do your best imitation of the existing code style. For anything you might add there's almost always a precedent that can be followed.

@SJ-Innovation
Copy link
Contributor Author

Will do, thank you for your patience.

@thinkyhead thinkyhead force-pushed the bf2_LinAdv_DistinctKFactor branch from 6bdb19b to 63196b2 Compare September 10, 2018 10:04
@thinkyhead thinkyhead merged commit 4f883d5 into MarlinFirmware:bugfix-2.0.x Sep 11, 2018
@SJ-Innovation SJ-Innovation deleted the bf2_LinAdv_DistinctKFactor branch January 2, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants