[2.0.x] Fix extruder stops extruding with LA#11758
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Sep 9, 2018
Merged
[2.0.x] Fix extruder stops extruding with LA#11758thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
|
Tested, and have not noticed any strange with it. |
Contributor
|
I'm using an Ender 3 controlled by an Azteeg X5 Mini Wifi with TMC2224 (TMC2208) drivers. Whenever I enable LA and set to 0, the extruder will not work. So far I only tried the pattern generator code files. Any tips? |
Contributor
|
Just thought of something, would junction deviation cause any issues? |
Member
|
We've been over it and I believe we resolved all issues of JD interaction with LA. |
Contributor
Author
|
I'm using JD together with LA all the time, no issues. As you found out already, this is a stealth chop issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11711 and #9899.
When the advance ISR rate of the current block is identical to the advance ISR rate of the previous block and the current block has no acceleration phase the advance ISR will not be started as it should. The esteps during the cruising phase will then not trigger the advance ISR any longer due to:
The assumption was that each block enters the acceleration planning block at least once so the extruder ISR gets started. As this is false, I now initialise the extruder ISR when the new block is set up. On the other side, we can now remove some code lines as
LA_isr_rateis always started in a defined state at the beginning of the block.I tested the change with @Itox001 configuration which is known to cause the issue and it solves it. Also K=0 and my own configuration was tested.
Calling @Itox001, @buchnoun and @SJ-Innovation please give this PR a try before it gets merged. I had a ton of problems with the quite buggy Arduino 1.9 beta which I used for the 2.0.x code and it's quite late now, don't want to get a buggy fix merged due to fatigue!