[2.0.x] Show manual extrusion moves as relative in LCD#11733
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom Sep 6, 2018
Merged
Conversation
- Implements FR#11724 - Old behavior can be restored by commenting out MANUAL_E_MOVES_RELATIVE
73806a5 to
679e460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Detailed Description:
Suppose the user wants to extrude 50mm from E1 and 10mm from E2 at powerup. Currently, this is what they have to do:
To an end-user this makes no sense and isn't particularly helpful if they want to extrude or retract a particular amount of filament without having to do math. For the users, it would make more sense if it worked like this:
This PR enables this functionality by storing the current value of the E axis when the user enters the "Extruder " screen and subtracting that out from the value that is shown in the adjuster. That way, the adjuster will always begin at 0 mm and will represent a relative offset, rather than an absolute position.
If someone prefers to see absolute positions, this can be restored by commenting out
MANUAL_E_MOVES_RELATIVE(I suggest this feature be left enabled by default in the config as it improves usability for most users).