[2.0.x] SECURITYFIX missing max temp error when PID is used#11717
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom Sep 5, 2018
Merged
[2.0.x] SECURITYFIX missing max temp error when PID is used#11717thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Adding the ability to get max temp errors while tuning the PID parameters broke the ability to trow these errors during normal use.
And remove the dependency to heater on for the max_temp_error to get errors when booting with a stuck/overtemeratured heater.
Contributor
Author
|
See comments in #11718. |
Member
|
@AnHardt — Does this affect the behavior we applied a while ago, where temp errors would only be thrown during heating? I remember we added that so it would be possible to run the machine without any thermistors connected, for testing and development, as long as heaters are off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to get max temp errors while tuning the PID parameters broke the ability to throw these errors during normal use.
Adding the new condition would have been better than replacing the old one.
Related issues:
#11643 "Printer increases temp to 325C when set to 235C on second layer WITH thermal runaway enabled"
caused by
#8126 "Fix M303 thermal protection"
#8103 "Marlin 115 tried to burn my house down during PID tuning"