[2.0.x] Use the new const functions of the persistentStore api #11544
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom Aug 14, 2018
hasenbanck:const-eeprom
Merged
[2.0.x] Use the new const functions of the persistentStore api #11544thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom hasenbanck:const-eeprom
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
hasenbanck:const-eeprom
Conversation
gloomyandy
reviewed
Aug 14, 2018
Contributor
gloomyandy
left a comment
gloomyandy
left a comment
There was a problem hiding this comment.
line 79 printercounter.cpp:
persistentStore.write_data(address, (uint8_t*)0x16, sizeof(uint8_t));
This does not look right. Do you really want to write whatever data is at location 0x16 in RAM into the store?
Contributor
Author
|
You're right. This slipped through with 577aeb4 . I will add the fix right away. |
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
0226dcc to
834ea7f
Compare
I cleaned up some functions by using the new const functions of the peristentStore api.
We want to save value 0x16 and not write the value of 0x16 into the address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I cleaned up some functions by using the new const functions of the peristentStore api.
Benefits
Code cleanup. Consistent API usage.