Skip to content

[2.0.x] Compile only HAL for selected PIO environment#11519

Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
fiveangle:bf2-pio_compile_only_selected_hal
Aug 14, 2018
Merged

[2.0.x] Compile only HAL for selected PIO environment#11519
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
fiveangle:bf2-pio_compile_only_selected_hal

Conversation

@fiveangle
Copy link

@fiveangle fiveangle commented Aug 11, 2018

Any interest in this @thinkyhead ?

  • Reasonable speed-up on builds (which should further reduce travis build time)
  • Adds a small level of compile failure isolation when specific platform builds break
  • Consolidates "shared" HAL files so they aren't littered in the main HAL directory (will hopefully keep additional "shared" resources from accumulating in different directories)

@fiveangle fiveangle changed the title [2.0.x] Compile only selected PIO environment [2.0.x] Compile only HAL for selected PIO environment Aug 11, 2018
@fiveangle fiveangle force-pushed the bf2-pio_compile_only_selected_hal branch 2 times, most recently from 910e235 to c72d57e Compare August 11, 2018 01:01
@fiveangle
Copy link
Author

fiveangle commented Aug 11, 2018

Hold up as it appears my rebase picked up a few rreverts. Will fix them up when back.

EDIT: All fixed up

@fiveangle fiveangle force-pushed the bf2-pio_compile_only_selected_hal branch 3 times, most recently from 23515bc to b421135 Compare August 11, 2018 18:35
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 3 times, most recently from eb2d6cb to cc0a604 Compare August 14, 2018 04:44
@thinkyhead
Copy link
Member

I do like the idea. I can try to rebase it after applying some persistent store patches.

@thinkyhead thinkyhead added PR: Improvement T: HAL & APIs Topic related to the HAL and internal APIs. labels Aug 14, 2018
@thinkyhead thinkyhead force-pushed the bf2-pio_compile_only_selected_hal branch 5 times, most recently from e72dbb0 to 6880d6f Compare August 14, 2018 07:07
@thinkyhead thinkyhead force-pushed the bf2-pio_compile_only_selected_hal branch from 6880d6f to ecee191 Compare August 14, 2018 08:27
@thinkyhead thinkyhead merged commit c641999 into MarlinFirmware:bugfix-2.0.x Aug 14, 2018
@fiveangle fiveangle deleted the bf2-pio_compile_only_selected_hal branch August 15, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: Build / Toolchain PR: Improvement T: HAL & APIs Topic related to the HAL and internal APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants