Skip to content

[2.0.x] Account for UBL correction when setting the planner position#11486

Merged
Roxy-3D merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
tcm0116:retract_ubl
Aug 10, 2018
Merged

[2.0.x] Account for UBL correction when setting the planner position#11486
Roxy-3D merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
tcm0116:retract_ubl

Conversation

@tcm0116
Copy link
Contributor

@tcm0116 tcm0116 commented Aug 7, 2018

Description

Addresses the issue described in #11432. It's possible that the same issue may need to be addressed for other ABL systems, but that will require additional investigation.

This issue is also present in 1.1.9.

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 7, 2018

Is this tested and working on your printer?
This bugfix is important enough to put into bugfix_1.1.x ! Can we get a version for that too?

THANK YOU!!!!!

@tcm0116
Copy link
Contributor Author

tcm0116 commented Aug 8, 2018

@Roxy-3D I've got a print going currently that has several islands. The first attempt was a complete failure, but it's going smoothly now with this change.

I can put together a change for 1.1.x. It should be easy as it has the same FWRetract class as 2.0.x. Did we decide that bug fixes are still going into 1.1.x, just no new features?

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 8, 2018

It is my belief that bug fixes are still going into 1.1.x. And even if this isn't true, this bug fix is important enough I would suggest we make an exception.

@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 9, 2018

@tcm0116 I was waiting for the 1.1.x version just so I could merge them both at the same time.

@tcm0116 tcm0116 changed the title Account for UBL correction when setting the planner position [2.0.x] Account for UBL correction when setting the planner position Aug 10, 2018
@tcm0116 tcm0116 changed the title [2.0.x] Account for UBL correction when setting the planner position [1.0.x] Account for UBL correction when setting the planner position Aug 10, 2018
@tcm0116 tcm0116 changed the title [1.0.x] Account for UBL correction when setting the planner position [2.0.x] Account for UBL correction when setting the planner position Aug 10, 2018
@tcm0116
Copy link
Contributor Author

tcm0116 commented Aug 10, 2018

@Roxy-3D Done. I was waiting for the Travis build to finish, but it appears to be having issues.

@Roxy-3D Roxy-3D merged commit fc55f1d into MarlinFirmware:bugfix-2.0.x Aug 10, 2018
@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 10, 2018

THANK YOU!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants