[1.1.x] Treat TMC2660 like non-TMC#11485
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom Aug 10, 2018
Merged
[1.1.x] Treat TMC2660 like non-TMC#11485thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
Member
|
I think it would also be a good idea to modify the stealthchop and stallguard macros. Marlin/Marlin/Conditionals_post.h Lines 733 to 736 in f6ef58f Just don't remove them as they will be expanded again. |
Member
Author
How should they be modified? |
Member
|
We can remove the references to |
Member
Author
|
Ah, ok. I see that |
0e28d0e to
7dbf11a
Compare
7dbf11a to
2fb4767
Compare
thinkyhead
added a commit
that referenced
this pull request
Aug 13, 2018
thinkyhead
added a commit
that referenced
this pull request
Sep 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TMC2660 may not be supportable at this time, so for now simply remove them from the
HAS_TRINAMICcondition and treat them like other non-Trinamic stepper drivers.Counterpart to #11508