[2.0.x] Fix drivers.h dependency, defer macro evaluation#11450
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Aug 4, 2018
Merged
[2.0.x] Fix drivers.h dependency, defer macro evaluation#11450thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #11387.
Until macros are actually evaluated, they can refer to things that are not yet defined. So only
drivers.h,Configuration.h, andConditionals_LCD.hneed to be included ahead of using the macros defined indrivers.h. The first file that uses them isConfiguration_adv.h, so it must have its defines forX_DUAL_STEPPER_DRIVERSandDUAL_X_CARRIAGEahead of its uses.Counterpart to #11449