[2.0.x] Fix Dual X Carriage tool change crash#11447
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom Aug 4, 2018
Merged
[2.0.x] Fix Dual X Carriage tool change crash#11447thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
thinkyhead
commented
Aug 3, 2018
Marlin/src/module/tool_change.cpp
Outdated
Member
Author
There was a problem hiding this comment.
X2_MAX_POS is defined as the distance between the extruders when both are homed. It is not the same as the maximum position unless the X_HOME_POS (and X1_HOME_POS) are both zero. So the X2_MAX_POS here should probably be X1_MIN_POS + X2_MAX_POS.
thinkyhead
commented
Aug 3, 2018
Marlin/src/module/tool_change.cpp
Outdated
Member
Author
There was a problem hiding this comment.
Marlin knows how to set the endstops for Dual X in the update_software_endstops function, so that should be called here instead of adding extra logic here in tool_change.
thinkyhead
force-pushed
the
bf2_idex_crash_fix
branch
3 times, most recently
from
ce8e7c7 to
665cbfc
Compare
thinkyhead
commented
Aug 3, 2018
Marlin/src/module/tool_change.cpp
Outdated
Member
Author
There was a problem hiding this comment.
Change based on update to 1.1.x by @GMagician …
thinkyhead
force-pushed
the
bf2_idex_crash_fix
branch
2 times, most recently
from
4a1b674 to
3296740
Compare
thinkyhead
force-pushed
the
bf2_idex_crash_fix
branch
from
3296740 to
16b1bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #11425 by @silentninja1
Prevent move on tool change to out of bounds positions.
Followup to Issue #11252 with a different method that should be adaptable enough for other manufacturers. Tested on Formbot Trex2+.