Update Pins on MKS sBase#11357
Update Pins on MKS sBase#11357thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom forkoz:fix_sbase_pins
Conversation
Fix invalid pin and add some comments.
Marlin/src/pins/pins_MKS_SBASE.h
Outdated
| #define PIN_P0_17 P0_17 | ||
| #define PIN_P0_16 P0_16 | ||
| #define PIN_P0_14 P0_14 | ||
| #define PIN_P0_14 P0_15 |
There was a problem hiding this comment.
This definition seems a little strange. Should the define now read PIN_P0_15?
| // | ||
| // Connector J7 | ||
| // Note: These pins are all shared with the EXP1/EXP2 Connector. | ||
| // Using them with an LCD connected or configured will lead to hangs & crashes. |
There was a problem hiding this comment.
May be worth noting that although the cpu pins are shared, the J7 and EXP1 pins are not directly connected. The pins on EXP1 go via a level shifter (as do many of the pins on EXP1/EXP2).
There was a problem hiding this comment.
What's a better way to put it?
There was a problem hiding this comment.
I think what you have is fine. Perhaps just add. "The connection to EXP1 goes via a level shifter."
I was a little confused by your original comment as I'd previously tested the J7 pins with a meter to see if they were shared with any other external connections and they did not seem to be. It was only when digging deeper that I noticed there is a level shifter on the EXP1 connection which means they do not show as shared with a simple meter check. Might save someone else the same confusion.
There was a problem hiding this comment.
added digitally, if that doesn't make enough sense I'll just copy the above.
oops
better to add another line?
3 participants
Description
Fix invalid pin and add some comments.
Benefits
Easier identification of usable pins and some pin capabilities.
Related Issues
Don't be me and share end stops with the LCD.