Skip to content

Add Multi Unit Support for Max7219 to bugfix_2.0.0#11285

Merged
Roxy-3D merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
Roxy-3D:bugfix-2.0.x
Jul 19, 2018
Merged

Add Multi Unit Support for Max7219 to bugfix_2.0.0#11285
Roxy-3D merged 3 commits intoMarlinFirmware:bugfix-2.0.xfrom
Roxy-3D:bugfix-2.0.x

Conversation

@Roxy-3D
Copy link
Member

@Roxy-3D Roxy-3D commented Jul 16, 2018

Get parity with bugfix_1.1.x with respect to supporting more than 1 Max7219 in a chain.

Updated Max7219_idle() routine coming next using 16 LED's in row if available (instead of two lines of 8 LED's)

@Roxy-3D
Copy link
Member Author

Roxy-3D commented Jul 16, 2018

@thinkyhead Can you give guidance? I'm not sure what I'm fighting. But GitHub Desktop forced an update to a new version. And one of the files had a warning saying line endings were changed from New-Line to Carrage-Return / New-Line. I'm pretty sure I didn't do that. I think it is in the repository that way.

Roxy-3D added a commit that referenced this pull request Jul 17, 2018
…16 or more LED's

Change Max7219_idle_task() routines to use single line if X-Axis has 16 or more LED's

This gets bugfix_1.1.x at parity with #11285 when it gets merged.
@ejtagle
Copy link
Contributor

ejtagle commented Jul 17, 2018

Seems teensy35 build is failing due to a missing include path...

@thinkyhead
Copy link
Member

An update to the L6470 library broke Travis CI testing. I patched the issue, and will follow up with testing to see that the library still functions otherwise.

@Roxy-3D
Copy link
Member Author

Roxy-3D commented Jul 17, 2018

Thanks! I'll just wait patiently for this to be merged. I believe it is all correct. It compiles clean for the AVR's. And it looks like Travis is now saying "All checks have passed."

But I'll wait for you to merge it.

@Roxy-3D
Copy link
Member Author

Roxy-3D commented Jul 19, 2018

This should be safe to merge...

I'm confused about what you did with the example config files. I'm pretty sure I updated all the config files prior to doing the Pull Request. Those should have had the extra line:

#define MAX7219_NUMBER_UNITS 1   // Number of Max7219 units in chain.

in all the files?????

@Roxy-3D Roxy-3D merged commit 9660996 into MarlinFirmware:bugfix-2.0.x Jul 19, 2018
@Roxy-3D
Copy link
Member Author

Roxy-3D commented Jul 19, 2018

Now to clean up the Max7219_idle_tasks() for the case where the rotation is +/- 90 degrees. (And there is more than 1 Max7219 unit).

In this case... The Queue depth and head and tail pointer are better done on a column instead of a row.

thinkyhead pushed a commit that referenced this pull request Sep 22, 2018
…16 or more LED's

Change Max7219_idle_task() routines to use single line if X-Axis has 16 or more LED's

This gets bugfix_1.1.x at parity with #11285 when it gets merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants