Skip to content

[1.1.x] Fix Vellemann K8400 Configuration#11258

Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
kaimimue:Vellemann-K8400-Configuration-Fix
Jul 14, 2018
Merged

[1.1.x] Fix Vellemann K8400 Configuration#11258
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
kaimimue:Vellemann-K8400-Configuration-Fix

Conversation

@kaimimue
Copy link
Contributor

The maximum movement is 180mm for Velleman K8400.
An offset of Y_MIN_POS violates an assertion in SanityCheck.h

Code testet on Vellemann K8400 with Dual Extruder.

The maximum movement is 180mm for Velleman K8400.
An offset of Y_MIN_POS violates an assertion in SanityCheck.h

Code testet on Vellemann K8400 with Dual Extruder.
@thinkyhead thinkyhead merged commit 256f76d into MarlinFirmware:bugfix-1.1.x Jul 14, 2018
@thinkyhead thinkyhead changed the title Fix Vellemann K8400 Configuration [1.1.x] Fix Vellemann K8400 Configuration Jul 14, 2018
@kaimimue kaimimue deleted the Vellemann-K8400-Configuration-Fix branch July 14, 2018 09:31
@fiveangle
Copy link

fiveangle commented Jul 14, 2018

I submitted a PR to fix this long ago with the Travis tests. The travis tests were rejected but I guess Scott lost this fix in the mix.

I'm pretty sure the same problem exists on the single-head 8200 so you should fix that too. I don't have the printer, but I assumed the Y_MIN_POS of 20 was correct (due to dual-head carriage) and assumed Y_MAX_POS needed to be changed. Are you confident you tested movement all the way to far bed-edge on the Y axis ?

Please review: fiveangle@16d4127

+#define Y_MAX_POS ((Y_BED_SIZE) + (Y_MIN_POS))

You have the printer, so you make the call, but just wanted to make sure that all factors were considered.

@kaimimue
Copy link
Contributor Author

Your proposed fix is similar to my patch. In both case the y-axis can only move 180.
Why is your patch not the current version in the repository. Before my patch the movement was 200 for single head (what is wrong) and 180 for Dual-Head, but this version does not compile.

thinkyhead pushed a commit that referenced this pull request Sep 22, 2018
The maximum movement is 180mm for Velleman K8400.
An offset of `Y_MIN_POS` violates an assertion in `SanityCheck.h`.

Code tested on Vellemann K8400 with Dual Extruder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants