[1.1.x] Validate that X/Y_PROBE_OFFSET_FROM_EXTRUDER are integers#11255
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom Jul 13, 2018
Merged
[1.1.x] Validate that X/Y_PROBE_OFFSET_FROM_EXTRUDER are integers#11255thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
cmroche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description
Addition of two static_asserts into SanityCheck.h which validate that the X_PROBE_OFFSET_FROM_EXTRUDER and Y_PROBE_OFFSET_FROM_EXTRUDER values are infact integers, issuing an error in the event that a float our double is provided erroneously.
Benefits
Without these checks it is possible to compile (without bed level debugging enabled) and the UBL system will mostly run. However any
G29 Jxcommands will fail with the error "Could not complete LSF!".By adding this error the misconfiguration becomes immediately clear on compilation preventing a user from reaching the point of the error on
G29.Related Issues
Discussed in #11245