[1.1.x] Ensure good min/max stepper timing#11011
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom Jun 13, 2018
Merged
[1.1.x] Ensure good min/max stepper timing#11011thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
thinkyhead
force-pushed
the
bf1_honor_step_rate
branch
from
8587357 to
acbbe63
Compare
thinkyhead
force-pushed
the
bf1_honor_step_rate
branch
3 times, most recently
from
9c96776 to
4af97a9
Compare
thinkyhead
force-pushed
the
bf1_honor_step_rate
branch
from
4af97a9 to
9d91ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #11004 by @ejtagle
If
MINIMUM_STEPPER_PULSE_TIMEwas 0, then the minimum period was ignored. Enforce respecting the maximum stepper rate always.Also fix the improper calculations of timer counts to enforce that maximum stepper rate: Timer counts are not the same as instruction cycle count, so we must convert it using the pulse timer prescaler define