[2.0.x] Ensure pins are INPUT after attachInterrupt

[thinkyhead]

According to @ktand There's no need to set pins to input because attachInterrupt will do it automatically. Does this extend to all STM32Fx platforms?

[ktand]

@thinkyhead I think it depends on which STM32 Arduino core is being used. STM32GENERIC has a bug where it CHANGES the pinmode to input, with no pull up. The official Arduino_Core_STM32 doesn't modify the pinmode and that is how it should be, I believe.

[thinkyhead]

@ktand — In that case, would it make more sense to set the pin mode after attachInterrupt for extra insurance?

[ktand]

@thinkyhed - Ideally this should be fixed in STM32GENERIC. I have fixed this in my fork of STM32GENERIC and will submit a PR soon.But until then it could be a good idea to do as you suggested.

…

On Wed, Jun 6, 2018 at 5:06 AM Scott Lahteine ***@***.***> wrote: @ktand <https://github.com/ktand> — In that case, would it make more sense to set the pin mode *after* attachInterrupt for extra insurance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10928 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ8NJFeUVfLb-T_YBSVVuUyA4gZyGTabks5t50chgaJpZM4UYTXS> .

[ktand]

@thinkyhead I'm sorry but I misunderstood you. I was thinking you meant setting the pinMode for endstop-pins as defined in Configuration.h (ENDSTOPPULLUP, ENDSTOPPULLDOWN) after attachInterrupt. Just setting them to INPUT after attachInterrupt makes no sense as the attachInterrupt function in STM32GENERIC already does this. I think it would be best to just remove the SET_INPUT call.

[thinkyhead]

…the attachInterrupt function in STM32GENERIC already does this…

Do we need to set the pullup for STM32GENERIC?