[1.1.x] BQ Hephestos 2 - Update and bugfix#10902
[1.1.x] BQ Hephestos 2 - Update and bugfix#10902thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
|
Thanks! I also noticed a minor timing issue with my CR-10S stock graphical display in which the FR % value looked glitchy. So we might want to apply this in other configurations too. |
There was a problem hiding this comment.
Best to leave this off by default until it's better-tested.
There was a problem hiding this comment.
Best to leave this off by default since it's an optional, not standard, feature. Or is it?
There was a problem hiding this comment.
Quick home is preferred, assuming it works properly. Does it?
There was a problem hiding this comment.
The logo is centered automatically, so there's no need to add padding 00000000's. And it saves on flash to leave them out.
There was a problem hiding this comment.
This is a regression. The DOGLCD option has been removed, and the LCD options have been rearranged in the latest configs.
There was a problem hiding this comment.
@thinkyhead I'm using this as reference.
Line 1387 in 3be22fc
There was a problem hiding this comment.
It's best to leave this on, if possible, for the benefit of host printing.
There was a problem hiding this comment.
This is a regression, and not the only one. We want this feature and other updated features to be included in all configs.
There was a problem hiding this comment.
When these are commented out, the most ideal values are automatically assigned in the Conditionals file, so it's best to leave them commented out.
There was a problem hiding this comment.
This is a regression. The comment has been reformatted.
There was a problem hiding this comment.
@thinkyhead I'm using this as reference.
Line 448 in 3be22fc
There was a problem hiding this comment.
This is a regression. The comment has been reformatted.
There was a problem hiding this comment.
@thinkyhead I'm using this as reference.
Line 441 in 3be22fc
There was a problem hiding this comment.
This is a regression. The spacing has been fixed.
There was a problem hiding this comment.
This comment may be helpful to leave in, along with leaving the HEPHESTOS2_HEATED_BED_KIT disabled by default.
Marlin/thermistortable_70.h
Outdated
There was a problem hiding this comment.
Is this new thermistor table confirmed accurate?
There was a problem hiding this comment.
Using a sample rate of one..
I always had issues with temperatures using the BQH2, the "normal" print temp for PLA was at 230 which is almost ABS range. So I decided to take a temp curve for the stock NTC and things are really different from what we have been using. I don't believe my NTC is broken, it's fairly consistent when I took the measurements.
All measurements were taken using a metallic probe force clamped into the heater block.
|
@jbrazio — This should be re-done starting from the most up-to-date configuration file. This appears to be built on an out-of-date configuration. If you're very busy, I can take care of it at some point. |
|
Hi Scott, I'm out for the weekend, Monday will take your comments and update this PR. |
eede58b to
9180984
Compare
|
I've rebased the changes with your suggestions. |
This PR updates the BQ Hephestos 2 config files to work with the latest (bleeding edge) Marlin 1.1.x release.
The improvement on the LCD handling code created some timing issues with the BQ LCD, this PR comes with a small fix for that (delay 3 cycles at the end of every bit write).
The NTC-70 lookup table was updated, now temperatures are much more accurate.