Skip to content

[1.1.x] BQ Hephestos 2 - Update and bugfix#10902

Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
jbrazio:config/bqh2
Jun 8, 2018
Merged

[1.1.x] BQ Hephestos 2 - Update and bugfix#10902
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
jbrazio:config/bqh2

Conversation

@jbrazio
Copy link
Contributor

@jbrazio jbrazio commented May 30, 2018

This PR updates the BQ Hephestos 2 config files to work with the latest (bleeding edge) Marlin 1.1.x release.

The improvement on the LCD handling code created some timing issues with the BQ LCD, this PR comes with a small fix for that (delay 3 cycles at the end of every bit write).

The NTC-70 lookup table was updated, now temperatures are much more accurate.

@thinkyhead
Copy link
Member

thinkyhead commented May 30, 2018

Thanks! I also noticed a minor timing issue with my CR-10S stock graphical display in which the FR % value looked glitchy. So we might want to apply this in other configurations too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to leave this off by default until it's better-tested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to leave this off by default since it's an optional, not standard, feature. Or is it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick home is preferred, assuming it works properly. Does it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo is centered automatically, so there's no need to add padding 00000000's. And it saves on flash to leave them out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression. The DOGLCD option has been removed, and the LCD options have been rearranged in the latest configs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkyhead I'm using this as reference.

* Enable ULTRA_LCD for a 16x2, 16x4, 20x2, or 20x4 character-based LCD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to leave this on, if possible, for the benefit of host printing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression, and not the only one. We want this feature and other updated features to be included in all configs.

Copy link
Member

@thinkyhead thinkyhead May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When these are commented out, the most ideal values are automatically assigned in the Conditionals file, so it's best to leave them commented out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression. The comment has been reformatted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkyhead I'm using this as reference.

// This option prevents a single extrusion longer than EXTRUDE_MAXLENGTH.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression. The comment has been reformatted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkyhead I'm using this as reference.

// This option prevents extrusion if the temperature is below EXTRUDE_MINTEMP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression. The spacing has been fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment may be helpful to leave in, along with leaving the HEPHESTOS2_HEATED_BED_KIT disabled by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new thermistor table confirmed accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a sample rate of one..
I always had issues with temperatures using the BQH2, the "normal" print temp for PLA was at 230 which is almost ABS range. So I decided to take a temp curve for the stock NTC and things are really different from what we have been using. I don't believe my NTC is broken, it's fairly consistent when I took the measurements.

All measurements were taken using a metallic probe force clamped into the heater block.

@thinkyhead
Copy link
Member

@jbrazio — This should be re-done starting from the most up-to-date configuration file. This appears to be built on an out-of-date configuration. If you're very busy, I can take care of it at some point.

@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 2, 2018

Hi Scott, I'm out for the weekend, Monday will take your comments and update this PR.

@jbrazio jbrazio force-pushed the config/bqh2 branch 3 times, most recently from eede58b to 9180984 Compare June 5, 2018 10:22
@jbrazio
Copy link
Contributor Author

jbrazio commented Jun 5, 2018

I've rebased the changes with your suggestions.

@thinkyhead thinkyhead changed the title BQ Hephestos 2 - Update and bugfix [1.1.x] BQ Hephestos 2 - Update and bugfix Jun 8, 2018
@thinkyhead thinkyhead merged commit 7aa7ecb into MarlinFirmware:bugfix-1.1.x Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants