[1.1.x] Malyan LCD compatibility#10836
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom May 24, 2018
Merged
[1.1.x] Malyan LCD compatibility#10836thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
thinkyhead
force-pushed
the
bf1_malyan_lcd_fix
branch
from
a760f56 to
fda3e84
Compare
thinkyhead
force-pushed
the
bf1_malyan_lcd_fix
branch
from
fda3e84 to
181516f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #6789 (comment)
Malyan LCD needs a second serial port to communicate with Marlin. This PR brings in
HardwareSerial.hfor the Malyan LCD in the case whereMarlinSerialreplaces theSerialinstance representing the USB port.To support this change, also add a
USE_MARLINSERIALconditional.Since
MarlinSerialdoesn't (?) provide a connected behavior likeif (Serial)just consider the USB connected status to betruewhenMarlinSerialis in use.