Skip to content

[2.0.x] EEprom code cleanup#10710

Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
GMagician:2.0.x-eeprom-code-cleanup
May 11, 2018
Merged

[2.0.x] EEprom code cleanup#10710
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
GMagician:2.0.x-eeprom-code-cleanup

Conversation

@GMagician
Copy link
Contributor

My purpose was to remove double "bed level system" message and looking into code I thought to "fix" also something other

  1. init_eeprom: removed unnecessary bool when "EEPROM_SETTINGS" is not defined;
  2. MarlinSettings::_load: removed 'reset' call since it is already called inside 'MarlinSettings::load' when something goes wrong

My purpose was to remove double "bed level system" message and looking into code I thought to "fix" also something other

1) init_eeprom: removed unnecessary bool when "EEPROM_SETTINGS" is not defined;
2) MarlinSettings::_load: removed 'reset' call since it is already called inside 'MarlinSettings::load' when something goes wrong
@thinkyhead thinkyhead merged commit d99f1b2 into MarlinFirmware:bugfix-2.0.x May 11, 2018
@GMagician GMagician deleted the 2.0.x-eeprom-code-cleanup branch May 12, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants