Change SDSS for the Printrboard to the correct pin#10675
Change SDSS for the Printrboard to the correct pin#10675Simon-Swenson-8351 wants to merge 1 commit intoMarlinFirmware:1.1.xfrom Simon-Swenson-8351:1.1.x
Conversation
…tes the need to remap the y-endstop to the e-endstop pin if using the SD card. See the Printrboard schematic: The SDCS pin is clearly marked on the block diagram as pin B6, not B0/SS
|
Thanks for your contribution! Unfortunately we can't accept PRs directed at release branches. We make patches to the bugfix branches and only later do we push them out as releases. Please redo this PR starting with the |
| #else | ||
| #define Y_STOP_PIN 20 // B0 SS - Ystop in Ystop socket | ||
| #endif | ||
| #define Y_STOP_PIN 20 // B0 SS |
There was a problem hiding this comment.
Is this pin marked as "SS", as the comment says?
There was a problem hiding this comment.
B0 is the default SS pin for the Teensy++ 2.0:
I think that was the source of the original confusion. It's just that the Printrboard doesn't use the default SS pin for the SD card, it uses B6.
There was a problem hiding this comment.
Oh yes, I have that diagram! Where the heck is PE2-PE3?
There was a problem hiding this comment.
Hmm, that's a good question. I think that PE2 and PE3 are the AVR register names, with corresponding pins on the IC, but those pins were probably just not given headers on the Teensy board. The Printrboard uses the same IC, hence it uses the same Arduino pin numbers as the Teensy (so I thought the diagram was useful), but since it's a standalone board, it can make use of all the registers it needs.
There was a problem hiding this comment.
Ah, makes sense. Of course, Printrboard is not Teensy, just "Teensy-like."
2 participants
This also eliminates the need to remap the y-endstop to the e-endstop pin if using the SD card. See the Printrboard schematic: The SDCS pin is clearly marked on the block diagram as pin B6, not B0/SS
Requirements
Description
The Printrboard uses the B0/SS pin (Arduino pin 20) as the y-endstop pin. In addition, according to the block diagram, the Printrboard actually has a SDCS pin on B6 (Arduino pin 26). When the original SDSS define in the header file was added, it was mistakenly added as the B0/SS pin number (Arduino pin 20), leading to a conflict between the y-endstop and the SDSS pin. This change fixes that conflict and assigns the SDSS define to the correct pin (26).
Benefits
Consistent y-endstop pin. No need to move the y-endstop connector to the e-endstop header if using an SD card. In addition, the SD card controller's SDCS pin will be pulled low when selected instead of being left floating. It seemed to work fine anyway, i.e., interpret a floating input as low, but that's generally a bad idea.
Related Issues
None.