Correct ATmega328P macro#10540
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom Apr 27, 2018
per1234:fix-atmega328p-macro
Merged
Correct ATmega328P macro#10540thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom per1234:fix-atmega328p-macro
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
per1234:fix-atmega328p-macro
Conversation
The correct MCU-specific macro for ATmega328P is __AVR_ATmega328P__, rather than __AVR_ATmega328p__, as was previously in the code.
thinkyhead
added a commit
that referenced
this pull request
Apr 27, 2018
…as with #10540 Co-Authored-By: per1234 <per1234@users.noreply.github.com>
thinkyhead
pushed a commit
that referenced
this pull request
Sep 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The correct MCU-specific macro for ATmega328P is
__AVR_ATmega328P__, rather than__AVR_ATmega328p__, as was previously in the code.Benefits
This bug caused a misleading error to be displayed when compiling for ATmega328P:
This would lead someone to believe the problem is that a pins definition for the microcontroller is required when actually a pins definition already exists but ATmega328P is still not supported.
After this fix compilation will still fail for ATmega328P, but without the misleading error.