Add DISABLED_Z_SENSORLESS_BY_PROBE conditional#10532
Add DISABLED_Z_SENSORLESS_BY_PROBE conditional#10532hideki22 wants to merge 1 commit intoMarlinFirmware:bugfix-1.1.xfrom hideki22:bugfix-1.1.x
Conversation
|
Forgive me but I don't understand the purpose of this. How is this any different from leaving the sensorless homing for z commented out. In addition if you are using a probe to home it overrides this anyways. |
|
Hello, I make this for fix this error in SanityCheck.h ( line 1470): #error "SENSORLESS_HOMING requires Z_MIN_ENDSTOP_INVERTING and ENDSTOPPULLUP_ZMIN when homing to Z_MIN."I have this error because I use BLTouch and need I found this in conditional_post.h ( line 665 ): // Disable Z axis sensorless homing if a probe is used to home the Z axis
#if ENABLED(SENSORLESS_HOMING)
#define X_SENSORLESS (ENABLED(X_IS_TMC2130) && defined(X_HOMING_SENSITIVITY))
#define Y_SENSORLESS (ENABLED(Y_IS_TMC2130) && defined(Y_HOMING_SENSITIVITY))
#define Z_SENSORLESS (ENABLED(Z_IS_TMC2130) && defined(Z_HOMING_SENSITIVITY))
#if HOMING_Z_WITH_PROBE
#undef Z_HOMING_SENSITIVITY
#endif
#endifBecause this comment, I need co,ment the line To facilitate this step, I add a conditional if enabled, Thank you. |
|
This would be better: #elif !HOMING_Z_WITH_PROBE && Z_SENSORLESS && Z_HOME_DIR == -1 && (DISABLED(Z_MIN_ENDSTOP_INVERTING) || DISABLED(ENDSTOPPULLUP_ZMIN))
#error "SENSORLESS_HOMING requires Z_MIN_ENDSTOP_INVERTING and ENDSTOPPULLUP_ZMIN when homing to Z_MIN."And this (in #if ENABLED(SENSORLESS_HOMING)
// Disable Z axis sensorless homing if a probe is used to home the Z axis
#if HOMING_Z_WITH_PROBE
#undef Z_HOMING_SENSITIVITY
#endif
#define X_SENSORLESS (ENABLED(X_IS_TMC2130) && defined(X_HOMING_SENSITIVITY))
#define Y_SENSORLESS (ENABLED(Y_IS_TMC2130) && defined(Y_HOMING_SENSITIVITY))
#define Z_SENSORLESS (ENABLED(Z_IS_TMC2130) && defined(Z_HOMING_SENSITIVITY))
#endif |
|
Thanks for the report! I've applied the needed change to |
Requirements
Description
Add control conditional to enable, disabled sensorless in Z when used a probe.
Benefits
Easy to enabled / disabled sensorless in Z when used a probe.
Related Issues