[1.1.x] Blink the value on non-homed axes#10523
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom May 10, 2018
Merged
[1.1.x] Blink the value on non-homed axes#10523thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
Member
|
|
Is there any scenario where a non homed axis makes any sense? Otherwise I would vote for a clear text message, e.g. "Axes not homed", "Home first" instead of blinking ? or values. |
Author
|
There isn't enough space to state that, and axes can be homed individually so we would need to be able state it per axis. Keeping the value is also important because knowing the delta from the starting position can be helpful, particularly when working on the unit |
Member
|
Rebased, repaired, completed.
|
8aa63eb to
505ee17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This kept tripping me up, Blinking a
?on the label suggests that the firmware isn't sure about the axis itself (such as it doesn't know what steppers is which axis), blinking the value more appropriately suggests that it isn't sure about the value.Benefits
Increasing native/intuitive understanding of status messages
Related Issues
fixes #3737