Skip to content

[1.1.x] Blink the value on non-homed axes#10523

Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
MrsTonedOne:patch-1
May 10, 2018
Merged

[1.1.x] Blink the value on non-homed axes#10523
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
MrsTonedOne:patch-1

Conversation

@MrsTonedOne
Copy link

Description

This kept tripping me up, Blinking a ? on the label suggests that the firmware isn't sure about the axis itself (such as it doesn't know what steppers is which axis), blinking the value more appropriately suggests that it isn't sure about the value.

Benefits

Increasing native/intuitive understanding of status messages

Related Issues

fixes #3737

@thinkyhead
Copy link
Member

thinkyhead commented Apr 26, 2018

  • Does the '?' / ' ' overwrite all the characters in the value?
    I suspect this will blink between 123 and ?23 or _23.
  • This also needs to be implemented for the graphical display.

@Sineos
Copy link

Sineos commented Apr 26, 2018

Is there any scenario where a non homed axis makes any sense? Otherwise I would vote for a clear text message, e.g. "Axes not homed", "Home first" instead of blinking ? or values.

@MrsTonedOne
Copy link
Author

MrsTonedOne commented Apr 26, 2018

There isn't enough space to state that, and axes can be homed individually so we would need to be able state it per axis. Keeping the value is also important because knowing the delta from the starting position can be helpful, particularly when working on the unit

@thinkyhead thinkyhead changed the title Axis errors blink the value, not the label. [1.1.x] Blink the value on non-homed axes May 9, 2018
@thinkyhead
Copy link
Member

thinkyhead commented May 9, 2018

Rebased, repaired, completed.

  • Implemented for graphical display.
  • Now overwrites the whole string.
  • Simply substitutes '?' for digits.

@thinkyhead thinkyhead merged commit a04fc8c into MarlinFirmware:bugfix-1.1.x May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants