[1.1.x] Simplify AVR preemptive interrupt handling#10501
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom Apr 24, 2018
Merged
[1.1.x] Simplify AVR preemptive interrupt handling#10501thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
thinkyhead
added
PR: Improvement
T: Development
thinkyhead
force-pushed
the
bf1_proper_avr_interrupts
branch
from
7a4d8b3 to
e94b518
Compare
thinkyhead
changed the title
thinkyhead
force-pushed
the
bf1_proper_avr_interrupts
branch
3 times, most recently
from
03ce270 to
8bd9ae8
Compare
Co-Authored-By: ejtagle <ejtagle@hotmail.com>
thinkyhead
force-pushed
the
bf1_proper_avr_interrupts
branch
from
8bd9ae8 to
f2e4536
Compare
Contributor
#if DISABLED(LIN_ADVANCE)
// Disable Timer0 ISRs and enable global ISR again to capture UART events (incoming chars)
DISABLE_TEMPERATURE_INTERRUPT();
DISABLE_STEPPER_DRIVER_INTERRUPT();
sei();
#endifIs not needed, as the isr prologue is already doing exactly this ;) |
Member
Author
|
Darn it. Thought I got that one. Thanks! |
thinkyhead
added a commit
that referenced
this pull request
Sep 22, 2018
Co-Authored-By: ejtagle <ejtagle@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up preemptive interrupt emulation for AVR.
in_temp_isr, intended to prevent a possible reentry.Based on #10496 by @ejtagle