[RFC] Adds the ability to have G29 execute a recovery and retry (10444)#10448
Closed
marcio-ao wants to merge 5 commits intoMarlinFirmware:bugfix-1.1.xfrom
Closed
[RFC] Adds the ability to have G29 execute a recovery and retry (10444)#10448marcio-ao wants to merge 5 commits intoMarlinFirmware:bugfix-1.1.xfrom
marcio-ao wants to merge 5 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
- Adds execute_commands_immediate_P() to execute GCODE macros from other GCODES. - Adds a G29_RECOVER_AND_RETRY which allows the user to specify a recovery sequence in G29_RECOVERY_COMMANDS
marcio-ao
force-pushed
the
rfc-retry-on-probe-fail
branch
from
06cfd98 to
276308a
Compare
- Added G29_ACTION_ON_RECOVER - Added G29_ACTION_ON_FAILURE
Contributor
Author
|
This has been replaced by #10450 on the bugfix-2.0.x branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thinkyhead: This isn't really a pull request, but simply soliciting your feedback on an implementation of the functionality I was asking about in 10444.
This code shows how to add a recover and retry option to G29 whose exact behavior can be controlled by the user in "Configuration.h" using a GCODE "macro". This implementation gets around the limitations of "enqueue_and_echo_commands_P" by executing the GCODE immediately using a new function "execute_commands_immediate_P".